Propagate additional_properties when using #[serde(flatten)]
#275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The MSRV check seems to be unrelated, and comes from rust-lang/cargo#9930. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259, motivated by stackabletech/operator-rs#752
Whether
NoneorSome(Schema::Object(...))is more permissive is arguably a matter of perspective. If you consider the JSON Schema to be a a validation target thenNonecould be argued to mean "and I don't care about anything else", while if it's a normative schema thenNonewould mean "and nothing else is accepted".Following the latter interpretation, any non-
Noneschema would be more permissive thanNone.I also believe that the expected behaviour is always that a "newtype" (a single flattened field) behaves identically to the type that it wraps, modulo explicitly requested differences.