Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sc336/notebook kernel link #2052

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Sc336/notebook kernel link #2052

merged 2 commits into from
Mar 27, 2023

Conversation

sc336
Copy link
Contributor

@sc336 sc336 commented Mar 21, 2023

PR type: doc improvement

Related issue(s)/PRs: resolves #2046

Summary

Proposed changes
Updates the link to point to the new kernels notebook. Improves some wording.

Fully backwards compatible: yes

PR checklist

  • New features: code is well-documented
    • detailed docstrings (API documentation)
    • notebook examples (usage demonstration)
  • The bug case / new feature is covered by unit tests
  • Code has type annotations
  • Build checks
    • I ran the black isort formatter (make format)
    • I locally tested that the tests pass (make check-all)
  • Release management
    • RELEASE.md updated with entry for this change
    • New contributors: I've added myself to CONTRIBUTORS.md

@codecov
Copy link

codecov bot commented Mar 21, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (e19233f) 98.01% compared to head (6e7ca95) 98.01%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2052    /-   ##
========================================
  Coverage    98.01%   98.01%           
========================================
  Files           96       96           
  Lines         5404     5404           
========================================
  Hits          5297     5297           
  Misses         107      107

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sc336 sc336 force-pushed the sc336/notebook-kernel_link branch from e17846f to 6e7ca95 Compare March 22, 2023 15:39
@sc336 sc336 merged commit 637b52d into develop Mar 27, 2023
@khurram-ghani khurram-ghani mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdutor vdutor vdutor approved these changes

@uri-granta uri-granta uri-granta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Reference to Manipulating Kernels Page
3 participants
@sc336 @vdutor @uri-granta