-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotated deploy key due to CircleCI security incident 2023-01-04 #2032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 97.98% // Head: 98.01% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2032 /- ##
===========================================
Coverage 97.98% 98.01% 0.03%
===========================================
Files 96 96
Lines 5401 5401
===========================================
Hits 5292 5294 2
Misses 109 107 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Rotated deploy key due to CircleCI security incident 2023-01-04 * Used the correct key this time * Touched to force rerunning tests Used the correct key this time Touched to force rerunning tests Updated config with new key
* Rotated deploy key due to CircleCI security incident 2023-01-04 * Used the correct key this time * Touched to force rerunning tests Used the correct key this time Touched to force rerunning tests Updated config with new key
… (#2033) * Rotated deploy key due to CircleCI security incident 2023-01-04 Updated config with new key
PR type: security issue
Related issue(s)/PRs: CircleCI had a security issue that requires some action
Summary
Proposed changes
Change the CircleCI deploy key (that is what this PR is doing; there are other key rotations also required)
Release notes
Fully backwards compatible: yes
PR checklist
make format
)make check-all
)