Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotated deploy key due to CircleCI security incident 2023-01-04 #2032

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

sc336
Copy link
Contributor

@sc336 sc336 commented Jan 6, 2023

PR type: security issue

Related issue(s)/PRs: CircleCI had a security issue that requires some action

Summary

Proposed changes
Change the CircleCI deploy key (that is what this PR is doing; there are other key rotations also required)

Release notes

Fully backwards compatible: yes

PR checklist

  • New features: code is well-documented
    • detailed docstrings (API documentation)
    • notebook examples (usage demonstration)
  • The bug case / new feature is covered by unit tests
  • Code has type annotations
  • Build checks
    • I ran the black isort formatter (make format)
    • I locally tested that the tests pass (make check-all)
  • Release management
    • RELEASE.md updated with entry for this change
    • New contributors: I've added myself to CONTRIBUTORS.md

Copy link
Member

@jesnie jesnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 97.98% // Head: 98.01% // Increases project coverage by 0.03% 🎉

Coverage data is based on head (13d466c) compared to base (df6ece2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2032       /-   ##
===========================================
  Coverage    97.98%   98.01%    0.03%     
===========================================
  Files           96       96              
  Lines         5401     5401              
===========================================
  Hits          5292     5294        2     
  Misses         109      107       -2     
Impacted Files Coverage Δ
gpflow/conditionals/util.py 100.00% <0.00%> ( 0.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@uri-granta uri-granta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sc336 sc336 merged commit 95f4f37 into develop Jan 9, 2023
@sc336 sc336 mentioned this pull request Jan 11, 2023
sc336 added a commit that referenced this pull request Jan 11, 2023
* Rotated deploy key due to CircleCI security incident 2023-01-04

* Used the correct key this time

* Touched to force rerunning tests

Used the correct key this time

Touched to force rerunning tests

Updated config with new key
sc336 added a commit that referenced this pull request Jan 11, 2023
* Rotated deploy key due to CircleCI security incident 2023-01-04

* Used the correct key this time

* Touched to force rerunning tests

Used the correct key this time

Touched to force rerunning tests

Updated config with new key
sc336 added a commit that referenced this pull request Jan 13, 2023
… (#2033)

* Rotated deploy key due to CircleCI security incident 2023-01-04

Updated config with new key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants