Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve transaction builder error #1037

Merged
merged 4 commits into from
Jul 11, 2023
Merged

feat: improve transaction builder error #1037

merged 4 commits into from
Jul 11, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Jul 10, 2023

closes: #1033

Checklist

  • I have linked to any relevant issues.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added the enhancement New feature or request label Jul 10, 2023
@hal3e hal3e requested a review from digorithm as a code owner July 10, 2023 10:57
@hal3e hal3e self-assigned this Jul 10, 2023
iqdecay
iqdecay approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@hal3e hal3e merged commit 5d97809 into master Jul 11, 2023
32 checks passed
@hal3e hal3e deleted the feat/improve-tx-builder-errors branch July 11, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@iqdecay iqdecay iqdecay approved these changes

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@hal3e hal3e

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vague error when ScriptTransactionBuilder is not given ConsensusParameters
4 participants
@hal3e @Br1ght0ne @iqdecay @segfault-magnet