Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use fuel-asm instead of fuel-vm #1032

Merged
merged 8 commits into from
Jul 21, 2023
Merged

chore: use fuel-asm instead of fuel-vm #1032

merged 8 commits into from
Jul 21, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Jul 7, 2023

Use fuel-asm directly where possible.

Checklist

  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added the tech-debt Improves code quality or safety label Jul 7, 2023
@hal3e hal3e self-assigned this Jul 7, 2023
iqdecay
iqdecay approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but think we want to wait for #997 so we can do the project-wide change @segfault-magnet mentioned.

segfault-magnet
segfault-magnet reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@segfault-magnet segfault-magnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might seem that you can remove even the last reference to fuel_vm over in provider.rs.

Take a look at the ProgramState type from the fuel client:
https://github.com/FuelLabs/fuel-core/blob/a57ad421e6b6714038f24815799bf8a499a2fd17/crates/client/src/client/schema/tx.rs#L142

@hal3e
Copy link
Contributor Author

hal3e commented Jul 11, 2023

It might seem that you can remove even the last reference to fuel_vm over in provider.rs.

Take a look at the ProgramState type from the fuel client: https://github.com/FuelLabs/fuel-core/blob/a57ad421e6b6714038f24815799bf8a499a2fd17/crates/client/src/client/schema/tx.rs#L142

Unfortunately we can not use the client type as TransactionStatus uses the vm's ProgramState and we can not convert it back.
https://github.com/FuelLabs/fuel-core/blob/a57ad421e6b6714038f24815799bf8a499a2fd17/crates/client/src/client/types.rs#L102

@hal3e hal3e merged commit 66e150e into master Jul 21, 2023
32 checks passed
@hal3e hal3e deleted the chore/use-fuel-asm-instead-vm branch July 21, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@iqdecay iqdecay iqdecay approved these changes

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne Br1ght0ne is a code owner

Assignees

@hal3e hal3e

Labels
tech-debt Improves code quality or safety
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hal3e @digorithm @iqdecay @segfault-magnet