Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: show README.md for fuels on crates.io #1026

Merged
merged 1 commit into from
Jul 4, 2023
Merged

docs: show README.md for fuels on crates.io #1026

merged 1 commit into from
Jul 4, 2023

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Jul 3, 2023 •
edited
Loading

Should show the top-level README.md for fuels (packages/fuels) on crates.io.
Not sure on how to test this besides merging and cutting a release to check crates.io.

Close #1025.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Br1ght0ne Br1ght0ne added the documentation Improvements or additions to documentation label Jul 3, 2023
@Br1ght0ne Br1ght0ne self-assigned this Jul 3, 2023
digorithm
digorithm approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. I remember being bothered by not seeing these docs on crates.io, but I forgot to open an issue, haha. Nice catch.

iqdecay
iqdecay approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@Br1ght0ne Br1ght0ne enabled auto-merge (squash) July 3, 2023 22:35
@Br1ght0ne Br1ght0ne merged commit cefc561 into master Jul 4, 2023
32 checks passed
@Br1ght0ne Br1ght0ne deleted the oleksii/crates-io-readme branch July 4, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@iqdecay iqdecay iqdecay approved these changes

@hal3e hal3e hal3e approved these changes

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@Br1ght0ne Br1ght0ne

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include a basic README for crates.io
4 participants
@Br1ght0ne @digorithm @iqdecay @hal3e