feat: add U256 support
#1014
Merged
feat: add U256 support
#1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
requested review from
digorithm,
iqdecay,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
There was a problem hiding this comment.
The JSON serialization of U256 seems a bit unexpected.
Take the following example:
let num: U256 = U256::from(123);
let serialized: String = serde_json::to_string(&num).unwrap();
eprintln!("{num} serialized is: '{serialized}'");
let num: u128 = 123;
let serialized: String = serde_json::to_string(&num).unwrap();
eprintln!("{num} serialized is: '{serialized}'");Which prints out:
123 serialized is: '"0x7b"'
123 serialized is: '123'
The U256 is serialized as hex while u128 is a stringified decimal number. Might take somebody by surprise.
Although it is probably faster to do the hex dump, I'd sacrifice the speed and go with the least surprising approach.
segfault-magnet
approved these changes
Jun 29, 2023
iqdecay
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1013
Adds support for sway's
U256type.Checklist