Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused MEM_MAX_ACCESS_SIZE #508

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Remove unused MEM_MAX_ACCESS_SIZE #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove MEM_MAX_ACCESS_SIZE, it was never actually used
  • Loading branch information
@Dentosal
Dentosal committed Aug 2, 2023
commit c16c3a6a2410040f83f0d06e354a699ef80e8536
12 changes: 0 additions & 12 deletions src/fuel-vm/instruction-set.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,7 1400,6 @@ Panic if:

- `$rA $rB` overflows
- `$rA $rB > VM_MAX_RAM`
- `$rB > MEM_MAX_ACCESS_SIZE`
- The memory range `MEM[$rA, $rB]` does not pass [ownership check](./index.md#ownership)

### MCLI: Memory clear immediate
Expand All @@ -1417,7 1416,6 @@ Panic if:

- `$rA imm` overflows
- `$rA imm > VM_MAX_RAM`
- `imm > MEM_MAX_ACCESS_SIZE`
- The memory range `MEM[$rA, imm]` does not pass [ownership check](./index.md#ownership)

### MCP: Memory copy
Expand All @@ -1436,7 1434,6 @@ Panic if:
- `$rB $rC` overflows
- `$rA $rC > VM_MAX_RAM`
- `$rB $rC > VM_MAX_RAM`
- `$rC > MEM_MAX_ACCESS_SIZE`
- The memory ranges `MEM[$rA, $rC]` and `MEM[$rB, $rC]` overlap
- The memory range `MEM[$rA, $rC]` does not pass [ownership check](./index.md#ownership)

Expand All @@ -1456,7 1453,6 @@ Panic if:
- `$rB imm` overflows
- `$rA imm > VM_MAX_RAM`
- `$rB imm > VM_MAX_RAM`
- `imm > MEM_MAX_ACCESS_SIZE`
- The memory ranges `MEM[$rA, imm]` and `MEM[$rB, imm]` overlap
- The memory range `MEM[$rA, imm]` does not pass [ownership check](./index.md#ownership)

Expand All @@ -1477,7 1473,6 @@ Panic if:
- `$rC $rD` overflows
- `$rB $rD > VM_MAX_RAM`
- `$rC $rD > VM_MAX_RAM`
- `$rD > MEM_MAX_ACCESS_SIZE`

### PSHH: Push a set of high registers to stack

Expand Down Expand Up @@ -1743,7 1738,6 @@ Panic if:
- `$rA $rD > VM_MAX_RAM`
- `$rB 32 > VM_MAX_RAM`
- The memory range `MEM[$rA, $rD]` does not pass [ownership check](./index.md#ownership)
- `$rD > MEM_MAX_ACCESS_SIZE`
- Contract with ID `MEM[$rB, 32]` is not in `tx.inputs`

### CROO: Code Merkle root
Expand Down Expand Up @@ -1802,7 1796,6 @@ Panic if:
- `$rA 32 > VM_MAX_RAM`
- `$ssp $rC >= $hp`
- `$rC > CONTRACT_MAX_SIZE`
- `$rC > MEM_MAX_ACCESS_SIZE`
- Contract with ID `MEM[$rA, 32]` is not in `tx.inputs`

Increment `$fp->codesize`, `$ssp` by `$rC` padded to word alignment. Then set `$sp` to `$ssp`.
Expand Down Expand Up @@ -1862,7 1855,6 @@ Panics if:

- `$rC $rD` overflows
- `$rA $rD > VM_MAX_RAN`
- `$rD > MEM_MAX_ACCESS_SIZE`

### MINT: Mint new coins

Expand Down Expand Up @@ -1897,7 1889,6 @@ Panic if:

- `$rA $rB` overflows
- `$rA $rB > VM_MAX_RAM`
- `$rB > MEM_MAX_ACCESS_SIZE`

Append a receipt to the list of receipts, modifying `tx.receiptsRoot`:

Expand Down Expand Up @@ -1988,7 1979,6 @@ Panic if:
- `$rB $rC` overflows
- `$rA 32 > VM_MAX_RAM`
- `$rB $rC > VM_MAX_RAM`
- `$rC > MEM_MAX_ACCESS_SIZE`
- `$rC > MESSAGE_MAX_DATA_SIZE`
- In an external context, if `$rD > MEM[balanceOfStart(0), 8]`
- In an internal context, if `$rD` is greater than the balance of asset ID 0 of output with contract ID `MEM[$fp, 32]`
Expand Down Expand Up @@ -2311,7 2301,6 @@ Panic if:
- `$rA 32 > VM_MAX_RAM`
- `$rB $rC > VM_MAX_RAM`
- The memory range `MEM[$rA, 32]` does not pass [ownership check](./index.md#ownership)
- `$rC > MEM_MAX_ACCESS_SIZE`

### S256: SHA-2-256

Expand All @@ -2330,7 2319,6 @@ Panic if:
- `$rA 32 > VM_MAX_RAM`
- `$rB $rC > VM_MAX_RAM`
- The memory range `MEM[$rA, 32]` does not pass [ownership check](./index.md#ownership)
- `$rC > MEM_MAX_ACCESS_SIZE`

## Other Instructions

Expand Down