Remove unused MEM_MAX_ACCESS_SIZE #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
added
documentation
Dentosal
requested review from
Voxelot,
SilentCicero,
xgreenx and
pixelcircuits
Dentosal
changed the title
|
I think it's fine to leave this out for now since we haven't found a practical use for it yet. We can always add it back in later if it's deemed necessary for the prover. |
Voxelot
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration value for it was fixed to
MEM_MAX_ACCESS_SIZE = VM_MAX_RAM. The rule against exceedingVM_MAX_RAMalways triggers first. See FuelLabs/fuel-vm#511 (comment) and the PR in general for the removal fromfuel-vm.