Make Nonce as 32 bytes array
#472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
previously approved these changes
Mar 17, 2023
Voxelot
approved these changes
Mar 17, 2023
|
Also updated the fuel-tx serialized format to make input message nonce bytes32, since it can be larger than uint64 according to the message id specification which states that it's determined by the chosen L1. |
pixelcircuits
approved these changes
Mar 18, 2023
nfurfaro
approved these changes
Mar 18, 2023
nfurfaro
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specs say that the
Nonceis a 32 bytes array but the current code usesWord. In the follow-up PR infuel-vmwe will replaceWordwith a 32-byte array.