Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: ShapeString Fuse caused single face string to lose fill #16809

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Sep 25, 2024

The faces.concatenate function can return a Face or a Compound. The code did not take that into account.

The `faces.concatenate` function can return a Face or a Compound. The code did not take that into account.
@Roy-043 Roy-043 added Mod: Draft Related to the Draft Workbench Needs backport Needs backport to 1.0 labels Sep 25, 2024
@maxwxyz maxwxyz added this to the 1.0 milestone Sep 25, 2024
@yorikvanhavre yorikvanhavre merged commit abc95b4 into FreeCAD:main Sep 25, 2024
9 checks passed
@yorikvanhavre yorikvanhavre removed the Needs backport Needs backport to 1.0 label Sep 25, 2024
@yorikvanhavre
Copy link
Member

merged and backported

@Roy-043 Roy-043 deleted the Draft-ShapeString-Fuse-caused-single-face-string-to-lose-fill branch September 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants