replace exec_program() with execute_process() #16728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent CMake (>= 3.28) do not allow exec_program() any more by default, but prefer execute_process(), which takes slightly different flags. According to the documentation, exec_program() has been deprecated since CMake 3.0 (which was released in 2014, so it should be common enough that I don't feel like making allowances for any really old CMake). References: https://cmake.org/cmake/help/latest/policy/CMP0153.html
|
Thanks for the PR -- I'm inclined to also back port it to the 1.0 branch, we will discuss it in tomorrow's PR review meeting. |
|
backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent CMake (>= 3.28) do not allow exec_program() any more by default, but prefer execute_process(), which takes slightly different flags. According to the documentation, exec_program() has been deprecated since CMake 3.0 (which was released in 2014, so it should be common enough that I don't feel like making allowances for any really old CMake).
References: https://cmake.org/cmake/help/latest/policy/CMP0153.html