Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fem: Use reference subshape transformation on the underlying geometry when finding points for constraint symbols #16673

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

marioalexis84
Copy link
Member

For trimmed surfaces, the algorithm to find reference points used by constraint symbols may fail. In that case points on the outer wire of the Face are used.
For this second case to work correctly the underlying surface must be transformed with the global placement of the reference face.

The following file shows the current incorrect behavior:
With the Sketch using the XZ plane as attachment support, the algorithm fails to generate points to place the Fem Constraint symbol because the global placement of the outer wire of the reference face is different from the placement of the underlying surface geometry.
If the attachment support is changed to the XY plane, the constraint symbols are generated. In this case the algorithm works because the placement of the outer wire of the face and the underlying surface are the same.

test_fail_points.FCStd.gz

@FEA-eng

@github-actions github-actions bot added the Mod: FEM Related to the FEM Workbench label Sep 20, 2024
@marioalexis84 marioalexis84 changed the title Fem: Use reference subshape transformation on the underlying geometry Fem: Use reference subshape transformation on the underlying geometry when finding points for constraint symbols Sep 20, 2024
@maxwxyz maxwxyz modified the milestones: 1.0, Post 1.0 Sep 20, 2024
@FEA-eng
Copy link
Contributor

FEA-eng commented Sep 20, 2024

I'll review it before M3.

@maxwxyz It's a bug fix, can you change the milestone to 1.0?

@maxwxyz maxwxyz modified the milestones: Post 1.0, 1.0 Sep 20, 2024
@chennes chennes self-assigned this Sep 20, 2024
@FEA-eng
Copy link
Contributor

FEA-eng commented Sep 23, 2024

Checked, works as expected.

@chennes chennes merged commit 5ff4d42 into FreeCAD:main Sep 23, 2024
9 checks passed
@chennes
Copy link
Member

chennes commented Sep 23, 2024

Cherry-picked to 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: FEM Related to the FEM Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants