[PD] Fix Pad uptoface with custom direction #16539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mod: Part Design
|
Might this also fix #14663 ? |
|
@AjinkyaDahale is going to record a macro that demonstrates the failure and fix. |
|
(Macro added in issue) |
|
I am still working on getting a working test. |
FlachyJoe
force-pushed
the
fix_16274
branch
2 times, most recently
from
678fd63
to
ffc53a6
Compare
FlachyJoe
force-pushed
the
fix_16274
branch
from
ffc53a6
to
1bc675c
Compare
|
@chennes did you see I added the unit test you required? |
|
I didn't, thank you! |
chennes
pushed a commit
that referenced
this pull request
Sep 24, 2024
* [PD] Fix Pad uptoface with custom direction * Add unit test
|
Cherry-picked to 1.0 -- thanks for fixing that other unit test as well, it took me a minute to figure out what had changed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16274