Gui: propertyeditor: Change setPropertyValue parameter to std::string #15970
104
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mod: Core
3x380V
force-pushed
the
propertyeditor
branch
2 times, most recently
from
ff745f0
to
b266d3b
Compare
3x380V
force-pushed
the
propertyeditor
branch
from
b266d3b
to
d10d9d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setPropertyValueparameter is later used asstd::stringin the function body. Following #15276 usesstd:stringfor Units too and these are used to constructsetPropertyValueinput string, so change its type to avoid back and forth conversion.