Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAM Fix minor sanity bugs #15934

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

sliptonic
Copy link
Member

set default directory for sanity
Respond correctly if user cancels
Fixes #14796

@github-actions github-actions bot added the Mod: CAM Related to the CAM/Path Workbench label Aug 17, 2024
@maxwxyz maxwxyz added this to the 1.0 milestone Aug 18, 2024
@WandererFan WandererFan marked this pull request as draft August 19, 2024 15:59
@sliptonic sliptonic force-pushed the SanityBugs branch 2 times, most recently from 530a43d to a6b7486 Compare September 2, 2024 20:52
@sliptonic sliptonic marked this pull request as ready for review September 2, 2024 20:52
@luzpaz
Copy link
Contributor

luzpaz commented Sep 2, 2024

Apologies for the the nit-pick, @sliptonic would you mind amending the commit so that the commit title and body are easily identifiable? Soft proposal:

git commit --amend -m "CAM: fix minor Sanity bugs" -m "Set default directory for sanity" - m "Respond correctly if user cancels" -m "Fixes #14796"
git push --force

@sliptonic
Copy link
Member Author

found a bug. Will revise.

@sliptonic sliptonic changed the title Fix minor sanity bugs CAM Fix minor sanity bugs Sep 9, 2024
Respond correctly if user cancels  Fixes FreeCAD#14796
@sliptonic sliptonic merged commit 6ac0cb7 into FreeCAD:main Sep 10, 2024
9 checks passed
@sliptonic sliptonic deleted the SanityBugs branch September 10, 2024 15:23
chennes pushed a commit that referenced this pull request Sep 10, 2024
Respond correctly if user cancels  Fixes #14796

Co-authored-by: Brad Collette <[email protected]>
luzpaz pushed a commit to luzpaz/FreeCAD that referenced this pull request Sep 10, 2024
Respond correctly if user cancels  Fixes FreeCAD#14796

Co-authored-by: Brad Collette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: CAM Related to the CAM/Path Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAM: Sanity check issues
3 participants