I don't love the removal of spaces from things like

if(SOMETHING)

That seems too compressed to my eye, so I'm inclined to also change that setting to enforce a space before the paren.

Comments welcome, we will talk about this in the next dev meeting.

Waiting for further review

Most of the auto-formatting is OK or acceptable but in cases like cMake/FreeCadMacros.cmake or src/Mod/Fem/CMakeLists.txt it completely breaks readability.

Most of the auto-formatting is OK or acceptable but in cases like cMake/FreeCadMacros.cmake or src/Mod/Fem/CMakeLists.txt it completely breaks readability.

Can you clarify which elements you are concerned about in those files? Nothing jumps out at me, so I'm not sure what to adjust in the configuration to resolve your comment.

ETA: If in the FreeCadMacros it was the argument list formatting, I've cleaned that up (the auto-formatter is very picky about what it recognizes as a list).

If in the FreeCadMacros it was the argument list formatting, I've cleaned that up (the auto-formatter is very picky about what it recognizes as a list).

Yes, this is what I was talking about. Looks much better now. Thanks!

But the problems in Fem's CMakeLists.txt file still exist. In the handwritten form one filename per line was used while now there are two or three filenames per line which is more difficult to read.

But the problems in Fem's CMakeLists.txt file still exist. In the handwritten form one filename per line was used while now there are two or three filenames per line which is more difficult to read.

I did some playing around with the max_pargs_hwrap setting in the formatter (which controls how many arguments before it switches to a vertical formatting), but any setting lower than the six it defaults to makes problems elsewhere. There is not any good fine-grained control, this formatter is sort of a bludgeon. I have put # cmake-format: off tags around the relevant blocks in FEM's cMakeLists.txt file and hand-formatted the lists to match the auto-formatter's vertical style. We could also exclude the FEM file from the pre-commit entirely, if you'd prefer.

Skipping this one at today's M3 since it's not blocking the RC