Gui: Optimize TreeWidget Context Menu Behavior with Sync View: Suppress Selection Change on Right-Click #15419
8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mod: Core
1 task
farleyrunkel
changed the title
1 task
farleyrunkel
changed the title
|
Thanks for the PR! This adds a new state to the code, so needs some further testing. In particular, the state is only set inside the mouse handling code, but selection can be changed in other ways (programatically, for example). Also, the ternary operator isn't necessary, since the result is a boolean. |
|
I'm switching this to draft pending updates to the code to ensure that state is correctly set and reset under other code paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses issue #15418 by fixing the incorrect context menu display when right-clicking on items in the TreeWidget, especially when the Sync View command is enabled.
The main reason for this issue is that right-clicking an item in Qt's QTreeWidget triggers the
onItemSelectionChangedevent, which activates the document item. As discussed in issue #13643, we shouldn't activate a document when right-clicking.To fix this, the selection change on right-click is suppressed. This ensures that the correct context menu appears, improving the user experience and keeping the functionality consistent.