Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize QT-style to Fusion #15868

Closed
2 tasks done
MisterMakerNL opened this issue Aug 12, 2024 · 11 comments · Fixed by #16042
Closed
2 tasks done

Normalize QT-style to Fusion #15868

MisterMakerNL opened this issue Aug 12, 2024 · 11 comments · Fixed by #16042
Labels
FDWG Input or discussion from FreeCAD Design Working Group needed Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Topic: User Interface Issue related UI/UX Type: Feature FR for improvements or new features

Comments

@MisterMakerNL
Copy link
Contributor

MisterMakerNL commented Aug 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

QT has different styles which are a pain to work with as a UI designer, why?
Well because basically you have to check at least 7 styles on issues.
You also get bug reports of those 7 styles.
And now we have windows 11 that seems to have issues with QT 6, as qt 6 attempt to adapt too windows 11 style. (windows 11 Qt-style? aka number eight?)
So even QT thought this was ridiculous and added 1 style to replace them all called Fusion.
And therefore I think it is a good idea to move Freecad too Fusion too, so Freecad looks the same on every OS.
Also it saves on development time.
For windows 11 it is probably wise to do this sooner than later since it breaks in QT 6.
@FreeCAD/design-working-group

Full version info

NA

Subproject(s) affected?

Core

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MisterMakerNL MisterMakerNL added the Status: Needs triage Missing triage label Aug 12, 2024
@MisterMakerNL
Copy link
Contributor Author

MisterMakerNL commented Aug 12, 2024

If you are a power user who wants to use his own QT style this is still possible but then you are on your own.

@maxwxyz maxwxyz added Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Topic: User Interface Issue related UI/UX Type: Feature FR for improvements or new features and removed Status: Needs triage Missing triage labels Aug 12, 2024
@krushia
Copy link

krushia commented Aug 15, 2024

You provide links for two different things: Qt Quick and QStyle. Which is this bug report about?

@obelisk79
Copy link
Contributor

This is certainly about QStyle. I generally agree that this should be standardized, however it's worth noting that this essentially will ensure FreeCAD does not follow a native UI style to the host operating system. I don't necessarily think that is bad, but it is definitely important to be aware of. Particularly for Mac users.

@MisterMakerNL
Copy link
Contributor Author

You provide links for two different things: Qt Quick and QStyle. Which is this bug report about?

Qstyle availability is OS depended, as I understand you can even make your own.
And so there isn't really a complete list, and the list although talking about qtquick is I think similar.

@krushia
Copy link

krushia commented Aug 15, 2024

Linux users (myself) will absolutely hate it if our configured QStyle is ignored. I'm not as concerned about Qt Quick, but we usually have that themed as well.

On Linux we have entire desktops running Qt. It isn't like on Windows where Qt is a weird thing that looks different. In KDE all our appearance settings change the Qt theme so applications look the same.

@MisterMakerNL
Copy link
Contributor Author

MisterMakerNL commented Aug 15, 2024

Hate it is a strong word, did you even try out Fusion?
What kind of difference do you see?
Btw I did say you don't have too use Fusion but it will be the default, you can do whatever you want with Freecad.
The idea is to get a stable basis for normal users.
Power users can do what-ever they feel like.

@krushia
Copy link

krushia commented Aug 15, 2024

This isn't a "power user" request. This is how desktops work. Users pick the widget style, the colors, the icons, the fonts, the cursors, the language, etc. These are configured once by the user and applications are expected to abide by the request.

If a newly installed FreeCAD did anything to override these settings, that would be a bug.

You really do not need to control these things. You just pick the type of widgets (combo/spinbox/textarea/...) needed and group them in a container. Qt applies the proper theme to those all by itself.*

Screenshot_20240815_181808

Not sure what there is for Qt configuration on Windows. Perhaps you can try https://github.com/RichardLuo0/qtct-for-windows to get a taste of how we do things on BSD/Linux where users control how things look.

  • I admit you need to specify the name of the style to apply to certain elements, and in very rare cases a custom widget will have no applicable default style.

@obelisk79
Copy link
Contributor

You presume too much about how many Linux users customize their desktops to that degree. Regardless of that sort of trivia, most FreeCAD stylesheets override much of how those styles look by default anyway according to your screenshot. I use fusion style, but with my themes, everything more closely resembles breeze (again, based on your screenshot)

This change also would impact windows and Mac users in similar ways to Linux. Linux users are just used to having more choice than the alternatives.

All this being said, it isn't some attempt to just foist a style choice into Linux users, rather address inconsistencies and problematic behavior exposed by supporting so many styles, operating systems, and Qt draw styles. Also, not even every Linux DE uses Qt so inconsistency between native/non-native widgets is going to be a problem no matter what.

@MisterMakerNL
Copy link
Contributor Author

We supply Freecad to 3 different OS, why wouldn't we make it look the same in every OS? WE can provide same support on every OS.
It's a CAD program, it has to do CAD stuff good the rest isn't important..
Further more I have more Linux computers than Windows and I have never been in the application style setting.
Also changing the handle of the slider from round to square is just a lot of stuff for such a trivial thing.
99% of users wouldn't notice nor care about the shape of your loading bar and slider.
So I agree with Oblisk I am very sure 99% of Freecad users will not notice and will not care if we do this.
Only as Kadett once stated that Mac users are probably the only one that will notice it as the Fusion style is a bit different as the mac style.

@luzpaz luzpaz added the FDWG Input or discussion from FreeCAD Design Working Group needed label Aug 23, 2024
@MisterMakerNL
Copy link
Contributor Author

Anyone against just setting the theme's to Qstyle fusion while leaving classic as how it is?

@MisterMakerNL
Copy link
Contributor Author

MisterMakerNL commented Aug 30, 2024

This article even says we should use fusion on Windows 11 as they did not do anything with the Qstyle windows, leaving us hanging with a broken Vista style.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FDWG Input or discussion from FreeCAD Design Working Group needed Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Topic: User Interface Issue related UI/UX Type: Feature FR for improvements or new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants