-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect names #2310
Comments
is this going live tomorrow? |
@davegandy please wait before the release, just take a look at the other couple of issues I added to 4.0.2 milestone |
@jdorfman Nope, not going live today. Work will likely get finished on Saturday or Sunday. I can wait to push till Monday if that makes your life easier. |
@tagliala Sounds good. |
Is this a complete list @davegandy or just the most egregious ones? |
@robmadole Should be the complete list. I don"t want to be renaming if I can manage it. Have any others you think are offenders? |
I think the only other ones that I was thinking of (that are not covered in an existing ticket: #2338) are |
@robmadole Got em, thanks for the reminder. |
Added to 4.0.2-wip branch, including updated documentation. |
@davegandy don"t forget this one in _config.yml version: 4.0.1 |
(and others) |
…is updated in v.4.0.2. For more info FortAwesome/Font-Awesome#2310
Just FYI, this was a breaking change. Not sure why this was done without a major version bump. |
@mnbayazit you are right. the proper way to manage issues like this is to deprecate old names and keep them until 5.0.0. We will pay more attention to this stuff |
@tagliala Thanks :-) Don"t mean to give you a hard time, just took me a little while to figure out why a bunch of my icons disappeared. |
A few icons are still named inconsistently or in an undesirable way.
fa-building -> fa-building-o
fa-hospital -> fa-hospital-o
fa-reorder -> fa-bars
fa-group -> fa-users (still be aliased as fa-group)
fa-unlock-o -> fa-unlock-alt (not an outlined version)
fa-resize-vertical -> fa-arrows-v
fa-resize-horizontal -> fa-arrows-h
fa-move -> fa-arrows
fa-fullscreen -> fa-arrows-alt
fa-resize-full -> fa-expand
fa-resize-small -> fa-compress
fa-ellipsis-vertical -> fa-ellipsis-v
fa-ellipsis-horizontal -> fa-ellipsis-h
Developing. Want to make sure the naming conventions are as good as they can be.
The text was updated successfully, but these errors were encountered: