Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect names #2310

Closed
davegandy opened this issue Nov 1, 2013 · 14 comments
Closed

Incorrect names #2310

davegandy opened this issue Nov 1, 2013 · 14 comments
Labels
Milestone

Comments

@davegandy
Copy link
Member

A few icons are still named inconsistently or in an undesirable way.

fa-building -> fa-building-o
fa-hospital -> fa-hospital-o
fa-reorder -> fa-bars
fa-group -> fa-users (still be aliased as fa-group)
fa-unlock-o -> fa-unlock-alt (not an outlined version)
fa-resize-vertical -> fa-arrows-v
fa-resize-horizontal -> fa-arrows-h
fa-move -> fa-arrows
fa-fullscreen -> fa-arrows-alt
fa-resize-full -> fa-expand
fa-resize-small -> fa-compress
fa-ellipsis-vertical -> fa-ellipsis-v
fa-ellipsis-horizontal -> fa-ellipsis-h

Developing. Want to make sure the naming conventions are as good as they can be.

@jdorfman
Copy link

jdorfman commented Nov 1, 2013

is this going live tomorrow?

@tagliala
Copy link
Member

tagliala commented Nov 1, 2013

@davegandy please wait before the release, just take a look at the other couple of issues I added to 4.0.2 milestone

@davegandy
Copy link
Member Author

@jdorfman Nope, not going live today. Work will likely get finished on Saturday or Sunday. I can wait to push till Monday if that makes your life easier.

@davegandy
Copy link
Member Author

@tagliala Sounds good.

davegandy added a commit that referenced this issue Nov 4, 2013
@robmadole
Copy link
Member

Is this a complete list @davegandy or just the most egregious ones?

@davegandy
Copy link
Member Author

@robmadole Should be the complete list. I don"t want to be renaming if I can manage it. Have any others you think are offenders?

@robmadole
Copy link
Member

I think the only other ones that I was thinking of (that are not covered in an existing ticket: #2338) are resize-small and resize-full.

@davegandy
Copy link
Member Author

@robmadole Got em, thanks for the reminder.

@davegandy
Copy link
Member Author

Added to 4.0.2-wip branch, including updated documentation.

@tagliala
Copy link
Member

tagliala commented Nov 4, 2013

@davegandy don"t forget this one in _config.yml

version: 4.0.1

@tagliala
Copy link
Member

tagliala commented Nov 4, 2013

(and others)

@mnpenner
Copy link

Just FYI, this was a breaking change. Not sure why this was done without a major version bump.

@tagliala
Copy link
Member

@mnbayazit you are right. the proper way to manage issues like this is to deprecate old names and keep them until 5.0.0.

We will pay more attention to this stuff

@mnpenner
Copy link

@tagliala Thanks :-) Don"t mean to give you a hard time, just took me a little while to figure out why a bunch of my icons disappeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants