Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade rn example app #2864

Merged
merged 5 commits into from
Sep 11, 2024
Merged

upgrade rn example app #2864

merged 5 commits into from
Sep 11, 2024

Conversation

zibs
Copy link
Contributor

@zibs zibs commented Apr 30, 2024 •
edited
Loading

Description

  • sets ground for working on RN app/symlinked to workspace
  • small type adjustments that came with upgrade
  • adds demo to pnpm workspace
  • adjusts metro config now that it actually supports symlinks
  • All examples seem to work except for one chart with a polar prop on it in the VictoryChart example screen, and the VictoryHistogram screen fixed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested by running on iOS and Android and clicking around. Clicked around web demo.

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c96d790

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 9:40pm

@zibs zibs force-pushed the feat/upgrade-rn-example branch from d41023d to 41b813e Compare June 6, 2024 20:15
@zibs zibs marked this pull request as ready for review June 7, 2024 15:31
@zibs zibs requested a review from carbonrobot June 7, 2024 15:32
@zibs zibs changed the title [draft] upgrade rn example app upgrade rn example app Jun 7, 2024
carbonrobot
carbonrobot previously approved these changes Sep 5, 2024
View reviewed changes
@zibs
Upgrade Example React Native application
4d3d066 
- sets ground for working on RN app/symlinked to workspace
- small type adjustments that came with upgrade
- adds demo to pnpm workspace
- adjusts metro config now that it actually supports symlinks
@zibs
hoistNonReactStatics in victory native
838a527 
It seems like certain attributes were not being hoisted in RN anymore, and so I've brought in this recommended package (https://legacy.reactjs.org/docs/higher-order-components.html#static-methods-must-be-copied-over)
@zibs
fix deps
ff3f691
@zibs
lint: no class names in RN
1f35905
@zibs
use >= for victory-native deps
c96d790
@zibs
Copy link
Contributor Author

zibs commented Sep 9, 2024

@carbonrobot had to rebase main and fix conflicts in the lock file in order to merge

@zibs zibs merged commit 7e79cfb into main Sep 11, 2024
9 checks passed
@zibs zibs deleted the feat/upgrade-rn-example branch September 11, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonrobot carbonrobot carbonrobot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zibs @carbonrobot