Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to net8.0 #2442

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

update to net8.0 #2442

wants to merge 11 commits into from

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Nov 26, 2023

fix #2426

I seem to have issue to load icon for setting panel. Could anyone reproduce that?

This is caused by low version of System.Drawing.Common. We may want to update other dependency as well. Somehow that works for me before but not now. Don't know what's going on. Might be some weird caching issue. Seems like if the resources font has the same name as one of the fonts installed by system it won't get loaded. So I rename the font to have the space replaced by -

  • Update System.Drawing.Common, FSharp.Core, Microsoft.Data.Sqlite to 8.0.0

This comment has been minimized.

This comment has been minimized.

@taooceros taooceros requested a review from jjw24 December 7, 2023 21:55

This comment has been minimized.

This comment has been minimized.

@jjw24
Copy link
Member

jjw24 commented Feb 4, 2024

Update README target version section please

@JohnTheGr8
Copy link
Member

Hey guys, is anything blocking this PR other than the readme change? Net7 has reached end of life, it's time to move on...

@jjw24 jjw24 added this to the 1.19.0 milestone May 22, 2024
@jjw24
Copy link
Member

jjw24 commented May 22, 2024

Believe so, let's get readme updated and merge dev in.

# Conflicts:
#	Flow.Launcher.Core/Flow.Launcher.Core.csproj
#	Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj
@jjw24 jjw24 modified the milestones: 1.19.0, Future Aug 16, 2024
# Conflicts:
#	Flow.Launcher.Core/Flow.Launcher.Core.csproj
#	Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj
#	Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
Copy link
Contributor

coderabbitai bot commented Aug 31, 2024

Walkthrough

Walkthrough

The changes involve updating multiple project files across a .NET application to target .NET 8.0 instead of .NET 7.0. This includes modifications to package references, resource inclusions, and publish profiles, ensuring the entire codebase aligns with the new framework version. The updates enhance compatibility with the latest framework features and improve resource management.

Changes

Files Change Summary
Flow.Launcher.Core/Flow.Launcher.Core.csproj, Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj, Flow.Launcher/Flow.Launcher.csproj, Flow.Launcher.Test/Flow.Launcher.Test.csproj, Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj, Plugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csproj, Plugins/Flow.Launcher.Plugin.Explorer/Flow.Launcher.Plugin.Explorer.csproj, Plugins/Flow.Launcher.Plugin.PluginIndicator/Flow.Launcher.Plugin.PluginIndicator.csproj, Plugins/Flow.Launcher.Plugin.PluginsManager/Flow.Launcher.Plugin.PluginsManager.csproj, Plugins/Flow.Launcher.Plugin.ProcessKiller/Flow.Launcher.Plugin.ProcessKiller.csproj, Plugins/Flow.Launcher.Plugin.Program/Flow.Launcher.Plugin.Program.csproj, Plugins/Flow.Launcher.Plugin.Shell/Flow.Launcher.Plugin.Shell.csproj, Plugins/Flow.Launcher.Plugin.Sys/Flow.Launcher.Plugin.Sys.csproj, Plugins/Flow.Launcher.Plugin.Url/Flow.Launcher.Plugin.Url.csproj, Plugins/Flow.Launcher.Plugin.WebSearch/Flow.Launcher.Plugin.WebSearch.csproj, Plugins/Flow.Launcher.Plugin.WindowsSettings/Flow.Launcher.Plugin.WindowsSettings.csproj Target framework updated from .NET 7.0 to .NET 8.0.
Scripts/flowlauncher.nuspec Target framework updated from net7.0 to net8.0.
Scripts/post_build.ps1 Updated publish profile path from Net7.0-SelfContained.pubxml to Net8.0-SelfContained.pubxml.
global.json Version updated from "7.0.*" to "8.0.*".

Assessment against linked issues

Objective Addressed Explanation
Support .NET 8.0 plugins (#2426)
Ensure compatibility with .NET 8.0 (#2426)
Update project configurations for .NET 8.0 (#2426)

Poem

🐇 In fields of code where rabbits play,
A leap to .NET 8.0 today!
With plugins bright and frameworks new,
We dance in bytes, our joy in view.
Hopping high, we celebrate,
A future fine, oh, isn't it great? 🐇✨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 09f60f3 and 559e846.

Files selected for processing (3)
  • .github/workflows/default_plugins.yml (13 hunks)
  • Flow.Launcher/Flow.Launcher.csproj (2 hunks)
  • README.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • README.md
Additional context used
Learnings (1)
Flow.Launcher/Flow.Launcher.csproj (1)
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-06-16T22:37:00.298Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.
Additional comments not posted (16)
Flow.Launcher/Flow.Launcher.csproj (3)

5-5: LGTM!

The target framework has been correctly updated to .NET 8.0.


81-83: LGTM!

The resource inclusion for TrueType font files has been correctly broadened to include all files in the Resources directory.


87-87: LGTM!

The CommunityToolkit.Mvvm package has been correctly updated to version 8.3.0.

.github/workflows/default_plugins.yml (13)

18-18: LGTM! .NET version updated to 8.0.x.

The .NET version update aligns with the PR objective of supporting .NET 8.0.


62-62: LGTM! Target framework updated to net8.0-windows for BrowserBookmark plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


89-89: LGTM! Target framework updated to net8.0-windows for Calculator plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


116-116: LGTM! Target framework updated to net8.0-windows for Explorer plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


143-143: LGTM! Target framework updated to net8.0-windows for PluginIndicator plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


170-170: LGTM! Target framework updated to net8.0-windows for PluginsManager plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


197-197: LGTM! Target framework updated to net8.0-windows for ProcessKiller plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


224-224: LGTM! Target framework updated to net8.0-windows10.0.19041.0 for Program plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0. The Windows version is kept the same.


251-251: LGTM! Target framework updated to net8.0-windows for Shell plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


278-278: LGTM! Target framework updated to net8.0-windows for Sys plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


305-305: LGTM! Target framework updated to net8.0-windows for Url plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


332-332: LGTM! Target framework updated to net8.0-windows for WebSearch plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


359-359: LGTM! Target framework updated to net8.0-windows for WindowsSettings plugin.

The target framework update is consistent with the .NET version update and is required for building the plugin with .NET 8.0.


Tip

Early access features: disabled

We are currently testing the following features in early access:

  • Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues on the discussion post.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This comment has been minimized.

Copy link

gitstream-cm bot commented Aug 31, 2024

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

…er found their windows version doesn't work) and update some dependency
@taooceros
Copy link
Member Author

@jjw24 so far everything works for me.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JohnTheGr8
Copy link
Member

@taooceros also need to update sdk version and TFMs here: https://github.com/Flow-Launcher/Flow.Launcher/blob/dev/.github/workflows/default_plugins.yml

This comment has been minimized.

Copy link

github-actions bot commented Sep 2, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
ℹ️ candidate-pattern 1
❌ ignored-expect-variant 1
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spelling/patterns.txt:

# Automatically suggested patterns

# hit-count: 1 file-count: 1
# Non-English
[a-zA-Z]*[ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź][a-zA-Z]{3}[a-zA-ZÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź]*

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link

gitstream-cm bot commented Sep 2, 2024

🥷 Code experts: Yusyuriv, jjw24

Yusyuriv, VictoriousRaptor have most 👩‍💻 activity in the files.
jjw24 has most 🧠 knowledge in the files.

See details

.github/workflows/default_plugins.yml

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:
jjw24: 95%

Flow.Launcher.Core/Flow.Launcher.Core.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:
jjw24: 14%

Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 0 additions & 2 deletions
APR

Knowledge based on git-blame:
jjw24: 13%

Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:
jjw24: 11%

Flow.Launcher.Test/Flow.Launcher.Test.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:
jjw24: 22%

Flow.Launcher/Flow.Launcher.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:
jjw24: 13%

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 83 additions & 7 deletions
APR

Knowledge based on git-blame:
jjw24: 38%

Plugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 4 additions & 4 deletions
APR

Knowledge based on git-blame:
jjw24: 19%

Plugins/Flow.Launcher.Plugin.Explorer/Flow.Launcher.Plugin.Explorer.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:
jjw24: 76%

Plugins/Flow.Launcher.Plugin.PluginIndicator/Flow.Launcher.Plugin.PluginIndicator.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:
jjw24: 20%

Plugins/Flow.Launcher.Plugin.PluginsManager/Flow.Launcher.Plugin.PluginsManager.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 3 additions & 2 deletions
APR

Knowledge based on git-blame:
jjw24: 85%

Plugins/Flow.Launcher.Plugin.ProcessKiller/Flow.Launcher.Plugin.ProcessKiller.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 2 additions & 1 deletions
APR

Knowledge based on git-blame:
jjw24: 9%

Plugins/Flow.Launcher.Plugin.Program/Flow.Launcher.Plugin.Program.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 2 additions & 0 deletions
APR

Knowledge based on git-blame:
jjw24: 17%

Plugins/Flow.Launcher.Plugin.Shell/Flow.Launcher.Plugin.Shell.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 8 additions & 7 deletions
APR

Knowledge based on git-blame:
jjw24: 14%

Plugins/Flow.Launcher.Plugin.Sys/Flow.Launcher.Plugin.Sys.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 6 additions & 5 deletions
APR

Knowledge based on git-blame:
jjw24: 15%

Plugins/Flow.Launcher.Plugin.Url/Flow.Launcher.Plugin.Url.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 6 additions & 5 deletions
APR

Knowledge based on git-blame:
jjw24: 18%

Plugins/Flow.Launcher.Plugin.WebSearch/Flow.Launcher.Plugin.WebSearch.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:
jjw24: 36%

Plugins/Flow.Launcher.Plugin.WindowsSettings/Flow.Launcher.Plugin.WindowsSettings.csproj

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 2 additions & 1 deletions
APR

Knowledge based on git-blame:

README.md

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY 163 additions & 155 deletions
APR

Knowledge based on git-blame:
jjw24: 26%

Scripts/flowlauncher.nuspec

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:
jjw24: 31%

Scripts/post_build.ps1

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:
jjw24: 16%

global.json

Activity based on git-commit:

Yusyuriv VictoriousRaptor
SEP
AUG
JUL
JUN
MAY
APR

Knowledge based on git-blame:

To learn more about /:\ gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support .NET 8.0 plugins
3 participants