-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated spanish copies #54530
Merged
carlosmiceli
merged 2 commits into
Expensify:main
from
jayeshmangwani:update_plan_type_copies
Dec 24, 2024
Merged
updated spanish copies #54530
carlosmiceli
merged 2 commits into
Expensify:main
from
jayeshmangwani:update_plan_type_copies
Dec 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DylanDylann its minor copy update, coming from our PR so tagging you here |
8 tasks
Reviewer Checklist
Screenshots/Videos |
@jayeshmangwani Could you merge the latest main to retrigger GH actions? |
DylanDylann
approved these changes
Dec 24, 2024
carlosmiceli
approved these changes
Dec 24, 2024
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
42 tasks
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.79-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #54525
PROPOSAL:
Tests
Verify that no errors appear in the JS console
Precondition:
App language is Spanish.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
![Simulator Screenshot - iPhone 15 Pro Max - 2024-12-24 at 18 48 47](https://github.com/user-attachments/assets/14dcdd08-6b39-4049-b776-633fee93347b)iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop