-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] fix: onboarding modal is not shown when redirecting from OD #54423
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2024-12-20.at.5.17.59.PM.movMacOS: Desktop |
cc @rlinoz |
@nkdengineer Change the first step to |
I updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
fix: onboarding modal is not shown when redirecting from OD (cherry picked from commit f0e8d60) (CP triggered by grgia)
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.0.77-6 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
@nkdengineer we don't have |
Yeah I think that is fine |
@izarutskaya Yes no need to check the apps. |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.77-6 🚀
|
Explanation of Change
fix: onboarding modal is not shown when redirecting from OD
Fixed Issues
$ #54419
PROPOSAL:
Tests
Offline tests
None
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2024-12-20.at.23.31.49.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-12-20.at.23.33.08.mov
MacOS: Chrome / Safari
Screen.Recording.2024-12-20.at.23.27.21.mov
MacOS: Desktop
Screen.Recording.2024-12-20.at.23.38.27.mov