-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump react-native-live-markdown to 0.1.210 #54326
Bump react-native-live-markdown to 0.1.210 #54326
Conversation
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🚧 @arosiclair has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
looking good on AdHoc screen-20241219-152010.mp4cc @eVoloshchak ready for your review |
cc @eVoloshchak bump on #54326 (comment) |
Reviewer Checklist
Screenshots/VideosAndroid: Nativevideo_2024-12-26_00-56-39.mp4Android: mWeb Chromevideo_2024-12-26_00-56-45.mp4iOS: NativeScreen.Recording.2024-12-26.at.00.54.57.moviOS: mWeb SafariScreen.Recording.2024-12-26.at.00.56.21.movMacOS: Chrome / SafariScreen.Recording.2024-12-26.at.00.46.47.movMacOS: DesktopScreen.Recording.2024-12-26.at.00.48.14.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.79-0 🚀
|
Explanation of Change
This is a bump of the
react-native-live-markdown
to version0.1.210
which includes only 1 change (Expensify/react-native-live-markdown#590) fixing the Android: Native issue where the live markdown styling wasn't being applied when revisiting Description field after saving markdown text and returning to the editing state.Fixed Issues
$ #53645
PROPOSAL: #53645 (comment)
Tests
Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android-mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios-mweb.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov