-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove lastMessageTranslationKey from report collection #54295
remove lastMessageTranslationKey from report collection #54295
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Don't forget to remove it from the whitelistedReportKeys as well. Should we update that test somehow so that it's not so easy to forget? |
yeah you are right, I keep forgetting that. I think it doesn't work properly because it should fail the TS job. I'll verify it as a separate issue. Meanwhile, I fixed it and updated the branch with main |
blocked by #54288 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2024-12-20.at.1.25.24.PM.movMacOS: DesktopScreen.Recording.2024-12-20.at.1.28.34.PM.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀
|
2 similar comments
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.78-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀
|
Explanation of Change
This PR removes
lastMessageTranslationKey
fromreport_
, since looks like it is not usedFixed Issues
$ #51867
PROPOSAL:
Tests
[Attachment]
Offline tests
n/a
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
android-web.mov
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov