-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: manage modal closing #54279
fix: manage modal closing #54279
Conversation
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
In the attached video I'm getting an error that I cannot delete the bank account, but it's ok - I cannot do that as I have an Expensify Card connected. But the video shows that I can interact with the screen and close this error message - the app is not frozen |
It is so weird I can reproduce this bug sometimes. It is inconsistent. But I agree with this solution, we shouldn't render a modal inside another one |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-19.at.18.12.45.movAndroid: mWeb ChromeScreen.Recording.2024-12-19.at.18.14.40.moviOS: NativeScreen.Recording.2024-12-19.at.18.13.10.moviOS: mWeb SafariScreen.Recording.2024-12-19.at.18.11.15.movMacOS: Chrome / SafariScreen.Recording.2024-12-19.at.18.09.47.movMacOS: DesktopScreen.Recording.2024-12-19.at.18.10.08.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.78-0 🚀
|
2 similar comments
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.78-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.78-0 🚀
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.78-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀
|
Explanation of Change
Fixed Issues
$ #52932
PROPOSAL: #52932 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-18.at.09.38.47.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop