Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

53182 submit button jump confirmation page #53529

Merged
merged 20 commits into from
Dec 25, 2024
Merged

53182 submit button jump confirmation page #53529

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift click to select a range
8250f05
prevent submit button from jumping when proceeding to the confirmatio…
huult Dec 3, 2024
53a6a35
Merge remote-tracking branch 'upstream/main' into 53182-submit-button…
huult Dec 4, 2024
c0d30f7
Update dismiss keyboard for web
huult Dec 4, 2024
ca09e27
Merge remote-tracking branch 'upstream/main' into 53182-submit-button…
huult Dec 4, 2024
c6368a5
Merge remote-tracking branch 'upstream/main' into 53182-submit-button…
huult Dec 5, 2024
ff74004
Add keyboard dismiss for web
huult Dec 5, 2024
0a6cd9e
Merge remote-tracking branch 'upstream/main' into 53182-submit-button…
huult Dec 9, 2024
c01e82c
Specify dismiss keyboard behavior for Android native and Safari on mo…
huult Dec 9, 2024
94b8c83
Merge remote-tracking branch 'upstream/main' into 53182-submit-button…
huult Dec 10, 2024
cbfc0d2
Merge remote-tracking branch 'upstream/main' into 53182-submit-button…
huult Dec 14, 2024
ff4fb89
add listen dimention changes
huult Dec 14, 2024
babeb3f
Merge remote-tracking branch 'upstream/main' into 53182-submit-button…
huult Dec 18, 2024
a89ea97
Merge remote-tracking branch 'upstream/main' into 53182-submit-button…
huult Dec 19, 2024
65345c4
Check visual viewport before setting maxHeight
huult Dec 19, 2024
968a125
Use visual viewport to detect keyboard show/hide
huult Dec 19, 2024
9917a1b
Remove unused break line
huult Dec 19, 2024
2d002c6
Merge remote-tracking branch 'upstream/main' into 53182-submit-button…
huult Dec 19, 2024
38f9e8c
Merge remote-tracking branch 'upstream/main' into 53182-submit-button…
huult Dec 24, 2024
c25b460
fix eslint
huult Dec 24, 2024
6704403
Update return default customUnitRateID when report ID is undefined
huult Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update return default customUnitRateID when report ID is undefined
  • Loading branch information
@huult
huult committed Dec 24, 2024
commit 670440364067251e855d0a9cd7a7aad5c5a3a666
5 changes: 3 additions & 2 deletions src/libs/DistanceRequestUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,13 290,14 @@ function convertToDistanceInMeters(distance: number, unit: Unit): number {
* Returns custom unit rate ID for the distance transaction
*/
function getCustomUnitRateID(reportID?: string) {
let customUnitRateID: string = CONST.CUSTOM_UNITS.FAKE_P2P_ID;

if (!reportID) {
return '';
return customUnitRateID;
}
const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
const parentReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID}`];
const policy = PolicyUtils.getPolicy(report?.policyID ?? parentReport?.policyID);
let customUnitRateID: string = CONST.CUSTOM_UNITS.FAKE_P2P_ID;

if (isEmptyObject(policy)) {
return customUnitRateID;
Expand Down
Loading