add top padding to LHN wrapper #53296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
hoangzinh
and removed request for
a team
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Tested the scrolling here as well and this looks good from a design perspective 👍 |
dubielzyk-expensify
previously approved these changes
Nov 29, 2024
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-08.at.21.45.09.movAndroid: mWeb Chrome
iOS: NativeScreen.Recording.2024-12-08.at.21.40.55.moviOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
|
hoangzinh
reviewed
Dec 2, 2024
src/styles/index.ts
Outdated
| @@ -1668,6 1668,7 @@ const styles = (theme: ThemeColors) => | |||
| }, | |||
|
|
|||
| sidebarListContainer: { | |||
| paddingTop: 12, | |||
There was a problem hiding this comment.
It works to me but @mkzie2 can you double check if we use that direct value in other pages like Search Page or workspace list? Curious if there is any existing shared variable on it
There was a problem hiding this comment.
We used mt3:
App/src/pages/Search/SearchTypeMenu.tsx
Line 251 in 6dff844
There was a problem hiding this comment.
Cool, what do you think if we reuse that value? Something like this
sidebarListContainer: {
...spacing.pt3,
paddingBottom: 4,
},
There was a problem hiding this comment.
@hoangzinh Agree, I updated.
|
@dubielzyk-expensify @mkzie2 do you think we would have a lot of space in LHN top in small screen devices?
Screen.Recording.2024-12-06.at.17.06.52.mov |
|
I think the space there is probably fine and is consistent with other pages. This is a one-line change though, how can we speed up the review? It feels like this one has been dragging on for a while. |
|
@shawnborton all goods. I can finish review checklist today |
hoangzinh
approved these changes
Dec 8, 2024
tylerkaraszewski
approved these changes
Dec 11, 2024
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
55 tasks
|
🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.0.75-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.75-6 🚀
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #52198
PROPOSAL: #52198 (comment)
Tests
Offline tests
NA
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop