-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove pinned SelfDM for new users #53193
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-11-27.at.22.11.04.mp4Android: mWeb ChromeScreen.Recording.2024-11-27.at.22.09.33.mp4iOS: NativeScreen.Recording.2024-11-27.at.22.08.36.mp4iOS: mWeb SafariScreen.Recording.2024-11-27.at.22.06.55.mp4MacOS: Chrome / SafariScreen.Recording.2024-11-27.at.22.12.16.mp4MacOS: DesktopScreen.Recording.2024-11-27.at.22.03.56.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wonder if it works without backend change 🤔 Is pinned state persisted after signing out or signing in? |
@MonilBhavsar Yes, we also need to retest after the backend change is complete. |
I have sent PR for backend. Will notify once it can be tested |
We can test with backend change now |
I'll test today |
@MonilBhavsar i merged and tested well |
Thanks for confirming! Let's ship it 🚀 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Performance regression is a false positive and can be ignored as of: |
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.70-0 🚀
|
@nkdengineer QA team encountered with this issue #53284 when checking the PR |
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.70-9 🚀
|
Explanation of Change
Fixed Issues
$ #52830
PROPOSAL: #52830 (comment)
Tests
Offline tests
same as above
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov