@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

As you can see in the videos there seems to be a lot of jumping going on after comment linking on native platforms (ios / android). It also happens on main so it is not related to this change. I will try to take some time soon to investigate those, especially important since we're going to use that case more now if opening at last unread.

I think we are cutting some messages when opening a link to a message, maybe it happens if the newer messages are already loaded?

@rlinoz Are you able to consistently reproduce? I am trying the same thing as the video, but the messages do load.

This is with messages already in cache.

Its on my radar, i'll review try to review this sometime tmrw 🙇

@ishpaul777 friendly bump

Are you able to consistently reproduce?

I will check again and try to get better steps

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Bug?: New message fetching and redering is quite jerky as compare to staging it often skips many messages load to end

staging

This branch

@ishpaul777 I can reproduce the problem, looking at it now, thanks!

That was harder that I thought to fix, I missed part of what the code did. It also handle pagination cases when new items are added, it adds it progressively to make sure no jumping happens.

Bug: Now i can't scroll down after linking to first any of the message and only linked messge is shown, after clear cache and restart

Oh strange, I was testing this exact case. Will check tomorrow.

Seems to only happen if the screen is high enough, that's why I didn't catch it during testing. I can now repro.

Hey @janicduplessis any news on this one?

Hey, I haven't had much availability in the past few weeks, will try to pickup work on it soon!

@janicduplessis Did you get chance to look into this?

Sorry about the delay, will be able to look at this tomorrow.

@ishpaul777 Are you still able to reproduce the issue? Weirdly I am not able to anymore even with increasing my screen resolution like I did last time.

i'll test again shortly 🙇

I can still reproduce, but on a different message not the first

@ishpaul777 I was finally able to reproduce the bug again. I am not sure exactly how, but once the app state is like this it happens all the time.

Basically if the CREATED action and the message we are linking to is loaded in cache, OpenReport is never called because of this code here.

This code is there to avoid calling OpenReport if we think that the data is already loaded, but it fails if the CREATED action is already loaded since it checks in sortedAllReportActions instead of the current page of data (reportActions).

To fix it I changed to check only in the current page of data (reportActions).

Let me know if that fixes it for you, it is hard to validate the fix as I am not able to consitently reproduce it.

I also noticed a little bit more jumping than usual when linking to the first message, I will see if I can fix that too. I suspect that moving the comment linking logic to BaseInvertedFlatList changed a bit how much ReportActionsView renders so it uncovered some bugs.

I added some more logic to limit how fast new items are added to the start of the list and now the jumping is gone.

i am jammed with many other priority tasks today will try to review tomorrow/coming days.

Hey @ishpaul777 did you have time to take a look at it?

also, @janicduplessis apparently we have some conflicts now

Yes I'll review today

Conflicts fixed

I think we may have broken the jump to new message button, but I can't repro every time

1. Hit clear cache and restart
2. Open the link to one of the messages in the chat with a lot of them
3. Click on New message

@janicduplessis friendly bump on the above

Any updates @janicduplessis ?