-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoicing details section #50571
Invoicing details section #50571
Conversation
…ture/45176-invoicing-details-section
…ture/45176-invoicing-details-section
…ture/45176-invoicing-details-section
…ture/45176-invoicing-details-section
…ture/45176-invoicing-details-section
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@alitoshmatov bump |
@rezkiy37 Everything seems to be working fine. One question though, why fullscreen loading is happening after updating company data? I see that data is being applied optimistically, what is causing loading then? |
That"s a reasonable question. AFAIK, this behavior is expected because was added 7 months ago. App/src/pages/workspace/WorkspacePageWithSections.tsx Lines 147 to 151 in 186c1a9
cc @madmax330 |
…ture/45176-invoicing-details-section
Reviewer Checklist
Screenshots/VideosAndroid: Nativecompany-android.movAndroid: mWeb ChromeiOS: Nativecompany-ios.mp4iOS: mWeb Safaricompany-safari.mp4MacOS: Chrome / Safaricompany-web.movMacOS: Desktopcompany-desktop.mov |
It does seem like it is not related to current PR, but we should definitely follow up on this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it"s a deploy blocker. |
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.56-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.56-9 🚀
|
@rezkiy37 FYI, QA was not run on this PR due to the QA test section being empty. I"m not sure if that was intended or not. The feature was not working and was reported as a deploy blocker in #51871. In the future, please add specific QA tests to your PRs or be more clear about why there are no QA tests. If you desire to have QA run the same tests as the "Tests" section, then please indicate so by adding "Same as tests" in the QA section. Thank you! |
Details
The PR introduces the API implementation for changing the invoice company name and website.
Fixed Issues
$ #45176
PROPOSAL: N/A
Tests
Preconditions:
WorkspaceInvoicingDetailsSection
) to the invoice page (WorkspaceInvoicesPage
). I am adding the section in the upcoming PR (Update Invoices setting screen #50565).Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android.mp4
Android: mWeb Chrome
Android.Chrome.mp4
iOS: Native
IOS.mp4
iOS: mWeb Safari
IOS.Safari.mp4
MacOS: Chrome / Safari
Chrome.mp4
MacOS: Desktop
Desktop.mp4