-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loading skeleton behind background #49039
Fix loading skeleton behind background #49039
Conversation
…x/47799-loading-behind-background
… accurate description
…x/47799-loading-behind-background
@Ollyws variable |
Reviewer Checklist
Screenshots/VideosAndroid: Native01_Android_Native.mp4Android: mWeb Chrome02_Android_Chrome.mp4iOS: Native03_iOS_Native.mp4iOS: mWeb Safari04_iOS_Safari.mp4MacOS: Chrome / Safari05_MacOS_Chrome.mp4MacOS: Desktop06_MacOS_Desktop.mp4 |
@Ollyws it appears the checklist automation not working (?) |
@wildan-m Sorry, just noticed that the background doesn't seem to be appearing on iOS, but it does on main. |
…x/47799-loading-behind-background
…github.com/wildan-m/App into wildan/fix/47799-loading-behind-background
@Ollyws seems regression from other PR, working fine after merged with main Kapture.2024-09-14.at.06.00.21.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.36-0 🚀
|
🚀 Deployed to production by https://github.com/grgia in version: 9.0.36-2 🚀
|
const shouldShowMostRecentReportAction = | ||
!!mostRecentReportAction && | ||
!ReportActionsUtils.isActionOfType(mostRecentReportAction, CONST.REPORT.ACTIONS.TYPE.CREATED) && | ||
!ReportActionsUtils.isDeletedAction(mostRecentReportAction); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flag doesn't check for one-expense/invoice reports and makes the preview to be displayed. As such, #49853 resulted.
Details
Fixed Issues
$ #47799
PROPOSAL: #47799 (comment)
Tests
Pre-condition: Create public room without any chat
Offline tests
Can't be tested while offline
QA Steps
Same as test
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Kapture.2024-09-12.at.09.30.56.mp4
Android: mWeb Chrome
Kapture.2024-09-12.at.09.34.43.mp4
iOS: Native
Kapture.2024-09-14.at.06.00.21.mp4
iOS: mWeb Safari
Kapture.2024-09-12.at.10.14.47.mp4
MacOS: Chrome / Safari
Kapture.2024-09-12.at.09.07.26.mp4
MacOS: Desktop
Kapture.2024-09-12.at.10.00.40.mp4