-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile image upload option doesn't show #48286
Profile image upload option doesn't show #48286
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeHaving issues with android build Android: mWeb ChromeScreen.Recording.2024-08-30.at.1.51.42.AM.moviOS: NativeScreen.Recording.2024-08-30.at.2.19.06.AM.moviOS: mWeb SafariScreen.Recording.2024-08-30.at.1.49.33.AM.movMacOS: Chrome / SafariScreen.Recording.2024-08-30.at.1.45.08.AM.movScreen.Recording.2024-08-30.at.1.49.01.AM.movMacOS: DesktopScreen.Recording.2024-08-30.at.1.47.08.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good!
…snt-show Profile image upload option doesn't show (cherry picked from commit dd2ffcf) (CP triggered by puneetlath)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.0.26-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀
|
Details
Fixed Issues
$ #48242
PROPOSAL: #48242 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Prerequisite: have a custom avatar set on the profile first
Android/iOS
Web/mWeb/Desktop
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4