Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

Job added to Upwork: https://www.upwork.com/jobs/~021872619802972851604

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

Upwork job price has been updated to $50

50$ to identify the offending PR and confirm with the revert.

I have demoted as I have tested and this is not a problem if the workspace is created online. Its very rare that the workspace would be created offline and user needs to update the name straight after

This is caused by #53529

@huult @suneox can you please have a look or should we revert your PR and address it later?

I'm checking

@mountiny I found the root cause of this issue. It was due to an update to eslint for getCustomUnitRateID, which caused this issue to occur.

May I revert this commit?

@mountiny I found the root cause of this issue. It was due to an update to eslint for getCustomUnitRateID, which caused this issue to occur.

App/src/libs/DistanceRequestUtils.ts

Lines 293 to 297 in 6704403

	let customUnitRateID: string = CONST.CUSTOM_UNITS.FAKE_P2P_ID;
	if (!reportID) {
	return customUnitRateID;
	}

May I revert this commit?

@huult Have you got solution to resolve this issue instead of only revert commit?

yes @suneox I will create pull request soon

@suneox @mountiny The pull request #54634 is ready. Could you take a look?

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

📣 @huult 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@huult @suneox can you please have a look or should we revert your PR and address it later?

@mountiny The PR doesn't resolve this issue, so I think we can revert PR until we find the root cause.

I haven't really dig into the issue, but I found that it's caused by the keyboard utils dismiss function of index.website.ts

@suneox Could you check again? thanks

@suneox Could you check again? thanks

Can you provide the RCA for this issue? In your new update, it only ignores iOS Safari, but I’ve double-checked this issue also occurs on the latest staging with iOS Safari (real device).

@suneox Yes, we have two issues here:

1. We updated ESLint and added a return early condition, which caused the send button to become unclickable. I have fixed this by removing the return early condition.

2. For dismissing the keyboard, we used visualViewport to detect and hide the keyboard. This should only work on Safari.

I tested it on the iOS version of the mobile web, and it’s working well.

1. We updated ESLint and added a return early condition, which caused the send button to become unclickable.

@huult Your RCA isn't correct.

Can you reference the code in your commit that makes the button unclickable?

2. For dismissing the keyboard, we used visualViewport to detect and hide the keyboard. This should only work on Safari

The issue occurs on a real device when the smart banner app is displayed.

Yes, I will check this case (the smart banner is displayed).

@suneox I have found the RCA of this issue. I will update the pull request in a few hours. The problem occurs because isVisible is not updated to false when the smart banner is displayed, causing the condition currentHeight === initialViewportHeight to fail

@suneox I have finalized the pull request. Could you check it again? Thank you!