Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Workspace - User selection is not cleared when reopening invite list from workspace profile #54604

Open
6 of 8 tasks
mitarachim opened this issue Dec 27, 2024 · 11 comments
Open
6 of 8 tasks

[$250] Workspace - User selection is not cleared when reopening invite list from workspace profile #54604

mitarachim opened this issue Dec 27, 2024 · 11 comments
Assignees
@anmurali @parasharrajat @techievivek
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@mitarachim
Copy link

mitarachim commented Dec 27, 2024 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Click Invite member.
  4. Select another member > Next.
  5. Close invite message page without inviting by clicking outside the RHP.
  6. Click Invite member again.
  7. Note that the previous selection is cleared.
  8. Go to Workspace profile.
  9. Click Invite.
  10. Select another member > Next.
  11. Close invite message page without inviting by clicking outside the RHP.
  12. Click Invite member again.

Expected Result:

The selection should be cleared.

Actual Result:

The selection is not cleared.
This issue only happens with the Invite button on Workspace profile page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6702809_1735286578549.20241227_155657.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021872610413601367629
  • Upwork Job ID: 1872610413601367629
  • Last Price Increase: 2024-12-27
Issue OwnerCurrent Issue Owner: @parasharrajat
@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 27, 2024

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 27, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 27, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot mentioned this issue Dec 27, 2024
Open
41 tasks
@daledah
Copy link
Contributor

daledah commented Dec 27, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selection is not cleared.
This issue only happens with the Invite button on Workspace profile page.

What is the root cause of that problem?

When navigating to invite member page in step 2, we had the logic to clear members

App/src/pages/workspace/WorkspaceMembersPage.tsx

Line 564 in e94df0f

onPress={inviteUser}

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 209 to 212 in e94df0f

const inviteUser = () => {
clearInviteDraft();
Navigation.navigate(ROUTES.WORKSPACE_INVITE.getRoute(route.params.policyID, Navigation.getActiveRouteWithoutParams()));
};

but we don't do that in

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 354 in e94df0f

onPress={() => Navigation.navigate(ROUTES.WORKSPACE_INVITE.getRoute(route.params.policyID, Navigation.getActiveRouteWithoutParams()))}

What changes do you think we should make in order to solve the problem?

We should move this logic here to util function and use it in

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 354 in e94df0f

onPress={() => Navigation.navigate(ROUTES.WORKSPACE_INVITE.getRoute(route.params.policyID, Navigation.getActiveRouteWithoutParams()))}

and

App/src/pages/workspace/WorkspaceMembersPage.tsx

Line 564 in e94df0f

onPress={inviteUser}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@techievivek
Copy link
Contributor

Demoting it since it's not deemed to be a deploy blocker.

@techievivek techievivek added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 27, 2024
@melvin-bot melvin-bot bot changed the title Workspace - User selection is not cleared when reopening invite list from workspace profile [$250] Workspace - User selection is not cleared when reopening invite list from workspace profile Dec 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021872610413601367629

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@parasharrajat
Copy link
Member

Reviewing...

@parasharrajat
Copy link
Member

@daledah's proposal looks good to me. I don't think this change warrants a util function. We should be good to use the clearInviteDraft on the profile page too.

🎀 👀 🎀 C reviewed

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 27, 2024

Current assignee @techievivek is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anmurali anmurali

@parasharrajat parasharrajat

@techievivek techievivek

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@anmurali @parasharrajat @techievivek @daledah @mitarachim