Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LHN - Tooltip appears for each workspace chat including invited member's workspace chat #54601

Closed
6 of 8 tasks
mitarachim opened this issue Dec 27, 2024 · 10 comments
Closed
6 of 8 tasks

LHN - Tooltip appears for each workspace chat including invited member's workspace chat #54601

mitarachim opened this issue Dec 27, 2024 · 10 comments
Assignees
@youssef-lr @sonialiap
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0
App Component: Left Hand Navigation (LHN)

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new account.
  3. Create a workspace, but do not go back to Inbox.
  4. Go to workspace settings > Members.
  5. Invite a few members.
  6. Go back to Inbox.

Expected Result:

There will be only one tooltip for the workspace chat which is the admin's own workspace chat.

Actual Result:

Tooltip appears for each workspace chat including invited member's workspace chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6702722_1735260216133.20241227_083953.mp4

View all open jobs on GitHub
@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 27, 2024

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 27, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 27, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot mentioned this issue Dec 27, 2024
Open
42 tasks
@youssef-lr youssef-lr mentioned this issue Dec 27, 2024
Merged
50 tasks
@youssef-lr
Copy link
Contributor

This is coming from here, I've asked the contributor to take a look.

@melvin-bot melvin-bot bot mentioned this issue Dec 27, 2024
Open
@ishpaul777 ishpaul777 mentioned this issue Dec 28, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 28, 2024
@ishpaul777
Copy link
Contributor

Raised the PR #54641

@Beamanator
Copy link
Contributor

CP'd PR just got to staging! @ishpaul777 if you have a moment, would you mind testing on staging?

@ishpaul777
Copy link
Contributor

Screen.Recording.2024-12-30.at.5.53.04.PM.mov

Fixed @Beamanator 🎉

@Beamanator
Copy link
Contributor

amazing, thanks so much!!

@Beamanator Beamanator removed Reviewing Has a PR in review DeployBlockerCash This issue or pull request should block deployment labels Dec 30, 2024
@Beamanator
Copy link
Contributor

closing as i believe no payment due here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youssef-lr youssef-lr

@sonialiap sonialiap

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Beamanator @youssef-lr @sonialiap @ishpaul777 @mitarachim