Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete card transactions when "allow deleting transactions" is disabled on card feed #54389

Open
joekaufmanexpensify opened this issue Dec 19, 2024 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@joekaufmanexpensify
Copy link
Contributor

joekaufmanexpensify commented Dec 19, 2024

Context

Third-party workspace card feeds in NewDot have an "allow deleting transactions" toggle on the feed settings. You should not be able to delete any card transactions imported while it was deleted. Similarly, you should be able to delete any transactions imported while it is enabled. The rule only applies to new transactions, eg: if you import transactions while this is disabled and later enable it, those past transactions can't be deleted and vice versa.

Problem

As discussed here, you can currently delete card transactions imported when this toggle is disabled, counter to how this feature is supposed to work.

2024-12-19_13-52-37.mp4

Solution

Fix the behavior of this feature for both custom and direct feeds such that it functions as originally described in the design doc.

Issue OwnerCurrent Issue Owner: @mountiny
@joekaufmanexpensify joekaufmanexpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 19, 2024
Copy link

melvin-bot bot commented Dec 19, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@kadiealexander
Copy link
Contributor

Just noting that I'll be OOO until Jan 6th, not reassigning given most people will be out but please tag someone online from the bug zero team if any urgent action is needed!

@DylanDylann
Copy link
Contributor

I would love to help on this issue as C

@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Dec 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 22, 2024
@mountiny
Copy link
Contributor

@DylanDylann not sure if there is much to do for you here

Copy link

melvin-bot bot commented Dec 26, 2024

@mountiny, @kadiealexander, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor

Havent got around yet

@melvin-bot melvin-bot bot removed the Overdue label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

4 participants