Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports-In report page, deleted expense is shown. #54365

Closed
2 of 8 tasks
mitarachim opened this issue Dec 19, 2024 · 16 comments
Closed
2 of 8 tasks

Reports-In report page, deleted expense is shown. #54365

mitarachim opened this issue Dec 19, 2024 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: V9. 0.77-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Search

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Login with new gmail account
  3. Tap fab - new workspace
  4. Navigate to reports
  5. Tap plus icon and create a expense using new workspace
  6. Long press the expense shown and delete it

Expected Result:

In report page, deleted expense must not be shown.

Actual Result:

In report page, deleted expense is shown.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6698968_1734614994847.Screenrecorder-2024-12-19-18-50-20-963_compress_1.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Dec 19, 2024
Copy link

melvin-bot bot commented Dec 19, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 19, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 19, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 19, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mitarachim
Copy link
Author

Issue not reproduce when we disabled Use Staging Server

bandicam.2024-12-19.15-36-56-222.mp4

@arosiclair
Copy link
Contributor

Confirmed that this is not reproducible with Use Staging Server disabled. This should be a web blocker.

@arosiclair arosiclair removed DeployBlockerCash This issue or pull request should block deployment Engineering labels Dec 19, 2024
@arosiclair
Copy link
Contributor

It doesn"t look like there"s anything wrong with DeleteMoneyRequestOnSearch on staging. The responses look similar on staging and prod.

Instead I think there"s something broken with creating the expense in RequestMoney. If I create the expense with prod and delete it with staging, it works fine. Only creating the expense on staging causes the issue.

@arosiclair
Copy link
Contributor

I"m more confused now.

  • I looked at the diff between staging and prod for RequestMoney and DeleteMoneyRequestOnSearch responses and didn"t notice any important differences
  • In DeleteMoneyRequestOnSearch response, there"s an update to clear the report and transaction from the snapshot but from logs and the values in IndexedDB, this is NOT being merged:
Screenshot 2024-12-19 at 12 19 37 PM

So I think the root of this problem lies more in the way we"re processing Onyx updates. Which means this might actually need to be an App blocker.

@arosiclair arosiclair added DeployBlockerCash This issue or pull request should block deployment and removed DeployBlocker Indicates it should block deploying the API labels Dec 19, 2024

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

@arosiclair
Copy link
Contributor

I don"t see any relevant App changes in the current deploy 😕. I"ll try reproducing this in dev and finding the root cause.

@arosiclair
Copy link
Contributor

Unfortunately, I"m having trouble reproducing in dev. And now even on staging I"m having trouble reproducing 🙃.

I think there"s probably a subtle bug with the way Onyx updates are handled here, but I don"t think any of the changes in the current deploy are causing it. I"m going to demote this and revisit next week to see if it"s still reproducible.

@arosiclair arosiclair added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 labels Dec 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
Copy link

melvin-bot bot commented Dec 23, 2024

@JmillsExpensify, @arosiclair Whoops! This issue is 2 days overdue. Let"s get this updated quick!

@arosiclair
Copy link
Contributor

No updates. Waiting until the next deploy.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 23, 2024
@arosiclair
Copy link
Contributor

Still not reproducible in v9.0.78-2:

Screen.Recording.2024-12-26.at.11.16.59.AM.mov

Closing this out

@melvin-bot melvin-bot bot removed the Overdue label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants