Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding flow - Guided Setup flow starts on the "What's your name" page #54361

Open
1 of 8 tasks
izarutskaya opened this issue Dec 19, 2024 · 20 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.77-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny @youssef-lr
Slack conversation (hyperlinked to channel name): https://applause-ts.slack.com/archives/C049HHMV9SM/p1734478516523379

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Add a new email
  3. Click Join
  4. Reload the page

Expected Result:

After step 3 we must see Onboarding modal and user should not need reload the page

Actual Result:

User must reload the page and Guided Setup flow starts on the "What's your name" page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-12-18.at.00.34.33.1.mov
Recording.858.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Dec 19, 2024
Copy link

melvin-bot bot commented Dec 19, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 19, 2024

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 19, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 19, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

Added two labels DeployBlocker as I can't disable Staging Server in this flow.

Production after reload the page

image

@Julesssss
Copy link
Contributor

I think this is likely front-end and related to other blockers, but for now I will leave the backend deploy label attached.

@mountiny
Copy link
Contributor

I can reproduce on main with produciton BE so removing the BE blocker label

@mountiny mountiny removed the DeployBlocker Indicates it should block deploying the API label Dec 19, 2024
@Julesssss
Copy link
Contributor

Hi @izarutskaya, can you help me understand what the difference is between this issue, where the flow is not shown on sign-in? In this case the user needs to refresh, but it seems that #54322 is the root issue here.

@joekaufmanexpensify
Copy link
Contributor

I agree with @Julesssss. It seems like the fix was handled in #54322 and is already CP'ed to staging, so thinking we can close this one?

@Julesssss
Copy link
Contributor

@joekaufmanexpensify there is a fix here, the issue is related to the step, NOT the page refresh as far as I can tell.

@shubham1206agra
Copy link
Contributor

Asking for assignment as per https://expensify.slack.com/archives/C02NK2DQWUX/p1734623191037589?thread_ts=1734623131.896299&cid=C02NK2DQWUX

@Julesssss
Copy link
Contributor

Thanks @shubham1206agra, please go ahead with review of this PR 👍

@joekaufmanexpensify
Copy link
Contributor

Ah, okay got it. TY!

@Julesssss Julesssss added the Reviewing Has a PR in review label Dec 19, 2024
@kavimuru
Copy link

Not reproduced

grabando__548.mp4

@joekaufmanexpensify
Copy link
Contributor

That is likely because the fix here was already deployed to staging.

@joekaufmanexpensify
Copy link
Contributor

Now that the fix is out on staging, bumping from hourly!

@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Hourly KSv2 labels Dec 19, 2024
@allroundexperts
Copy link
Contributor

Hi @joekaufmanexpensify!

This was a regression from a PR that I did. It was a pretty huge PR (some parts of it are still remaining). No payment pending for me here as an FYI.

@joekaufmanexpensify
Copy link
Contributor

Sweet, thanks for the heads up!

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Dec 20, 2024
@Julesssss
Copy link
Contributor

Verified fixed 👍 checking it off

@joekaufmanexpensify
Copy link
Contributor

As an fyi, I am OOO until the new year. Please ask in slack if anything urgent BZ related comes up. Otherwise, I will handle payment when I return!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants