-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding flow - Guided Setup flow starts on the "What's your name" page #54361
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
Triggered auto assignment to @Julesssss ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
I think this is likely front-end and related to other blockers, but for now I will leave the backend deploy label attached. |
I can reproduce on main with produciton BE so removing the BE blocker label |
Hi @izarutskaya, can you help me understand what the difference is between this issue, where the flow is not shown on sign-in? In this case the user needs to refresh, but it seems that #54322 is the root issue here. |
I agree with @Julesssss. It seems like the fix was handled in #54322 and is already CP'ed to staging, so thinking we can close this one? |
@joekaufmanexpensify there is a fix here, the issue is related to the step, NOT the page refresh as far as I can tell. |
Asking for assignment as per https://expensify.slack.com/archives/C02NK2DQWUX/p1734623191037589?thread_ts=1734623131.896299&cid=C02NK2DQWUX |
Thanks @shubham1206agra, please go ahead with review of this PR 👍 |
Ah, okay got it. TY! |
Not reproduced grabando__548.mp4 |
That is likely because the fix here was already deployed to staging. |
Now that the fix is out on staging, bumping from hourly! |
This was a regression from a PR that I did. It was a pretty huge PR (some parts of it are still remaining). No payment pending for me here as an FYI. |
Sweet, thanks for the heads up! |
Verified fixed 👍 checking it off |
As an fyi, I am OOO until the new year. Please ask in slack if anything urgent BZ related comes up. Otherwise, I will handle payment when I return! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.77-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny @youssef-lr
Slack conversation (hyperlinked to channel name): https://applause-ts.slack.com/archives/C049HHMV9SM/p1734478516523379
Action Performed:
Expected Result:
After step 3 we must see Onboarding modal and user should not need reload the page
Actual Result:
User must reload the page and Guided Setup flow starts on the "What's your name" page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Screen.Recording.2024-12-18.at.00.34.33.1.mov
Recording.858.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: