Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2024-12-18 #54292

Closed
72 tasks done
github-actions bot opened this issue Dec 18, 2024 · 18 comments
Closed
72 tasks done

Deploy Checklist: New Expensify 2024-12-18 #54292

github-actions bot opened this issue Dec 18, 2024 · 18 comments
Assignees
@jasperhuangg @applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited by jasperhuangg
Loading

Release Version: 9.0.77-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads
@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Dec 18, 2024
@tgolen
Copy link
Contributor

tgolen commented Dec 18, 2024

Demoted #54303

@amyevans
Copy link
Contributor

Checking off #54301, we reverted the offending PR

@kavimuru
Copy link

Regression is 67% progress
We still don't have android test build version for HybridApp and iOS updated just a while ago.
So all the iOS and Android PR slots are yet to be verified

#53239 (comment)

@izarutskaya
Copy link

izarutskaya commented Dec 19, 2024 •
edited
Loading

Regression is at 75% progress.
We still don't have Android build. All Android slots are waiting

PRs:
#51681 - failing with #51681 (comment)
#52955 - failing with #52955 (comment)
#53239 - can I check off based this comment #53239 (comment) ?
#54064 - revert - comment #54064 (comment) can I check off too?

DB:
#54322
#54327

@grgia
Copy link
Contributor

grgia commented Dec 19, 2024

Android build is still held.

@grgia
Copy link
Contributor

grgia commented Dec 19, 2024

The most recent build includes Android Hybrid (but not IOS Hybrid)

@arosiclair
Copy link
Contributor

I demoted #54365 (again)

@kavimuru
Copy link

kavimuru commented Dec 19, 2024 •
edited
Loading

We are still waiting for Android HybridApp.
Regression is 77% progress
#51681 failing with #54126 reproducible in PROD.
#52955 failing with #54307 reproducible in PROD
#53239 (comment) failing with original bug #53239 (comment)
#53688 failing with #54380 reproducible in PROD
#54064 failing with original bug #54064 (comment)

@izarutskaya
Copy link

We still don't have build Android HybridApp.
All Android slots are waiting.

Regression is 23% left

PRs:
#52483 - Found issue #52483 (comment) Repro in PROD
#54203 - Found issue when validation the PR #54203 (comment) Repro in PROD

DB:
#54361
#54388

@Julesssss
Copy link
Contributor

Checked off #54361, fixed by #54329

@grgia
Copy link
Contributor

grgia commented Dec 20, 2024

@izarutskaya @kavimuru, you should have Android now from the latest release. Could you confirm?

@grgia
Copy link
Contributor

grgia commented Dec 20, 2024

CPd fix for #54419

@mvtglobally
Copy link

@grgia Do not see the latest build yet. Team is seeing 9.0.76-3

@melvin-bot melvin-bot bot added the Monthly KSv2 label Dec 23, 2024
@izarutskaya
Copy link

izarutskaya commented Dec 23, 2024 •
edited
Loading

@grgia we have Android Hybrid 9.0.77.6

Regression is 2% left
#51681 - Failing with #54126 reproducible in PROD.
#52483 - Found issue #52483 (comment) Repro in PROD
#52955 - Failing with #54307 reproducible in PROD
#53239 (comment) - Failing with original issue #53239 (comment)

#53688 - Failing with #54380 reproducible in PROD
#54064 - Failing with original bug #54064 (comment)
#54203 - Found issue when validation the PR #54203 (comment) Repro in PROD
#54364 - Pending validation on Apps
#54423 - Pending validation on all environments

DB:
#54388
#54453

@kavimuru
Copy link

Regression is completed.
Unchecked PRs:
#51681 - Failing with #54126 reproducible in PROD.
#52483 - Found issue #52483 (comment) Repro in PROD
#52955 - Failing with #54307 reproducible in PROD
#53239 (comment) - Failing with original issue #53239 (comment)

#53688 - Failing with #54380 reproducible in PROD
#54064 - Failing with original bug #54064 (comment)
#54203 - Found issue when validation the PR #54203 (comment) Repro in PROD
#54364 - Blocked in HybridApps since onboarding is not possible. When creating account it will be created as OD account
Blockers:
#54388
#54453

@jasperhuangg jasperhuangg self-assigned this Dec 23, 2024
@jasperhuangg
Copy link
Contributor

Demoted #54388

@jasperhuangg
Copy link
Contributor

#54453 was demoted

@jasperhuangg
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasperhuangg jasperhuangg

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@tgolen @arosiclair @amyevans @Julesssss @jasperhuangg @applausebot @grgia @mvtglobally @kavimuru @izarutskaya