Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Job added to Upwork: https://www.upwork.com/jobs/~021867422219524271281

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

New message button disappears, and the message marked as unread is not shown as new after returning from a subthread.

What is the root cause of that problem?

We call goBack with shouldEnforceFallback as true so it always navigates to the fallback route here. Then a new report screen is added to the navigation stack which causes OpenReport API is called and the report is marked as read

What changes do you think we should make in order to solve the problem?

We should not pass shouldEnforceFallback as true. And we should use Navigation.isNavigationReady() to wait for the navigation action here

Navigation.isNavigationReady().then(() => {
    Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(parentReportID, parentReportActionID));
});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA (It's a UI issue)

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Edited by proposal-police: This proposal was edited at 2024-12-13 21:19:09 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat-New message button disappears when navigating back the the main chat from a thread

What is the root cause of that problem?

When navigating back from the thread we are linking to the parent report action and when the link has the report action id we want to position that specific report action as the bottom most report action to achieve that we slice report action list to the linkedReportActionIndex here on first render

What changes do you think we should make in order to solve the problem?

The fact that the message doesn't exist in prevSortedVisibleReportActionsObjects doesn't always mean that the message is a new message added because it could also be due to the report action not included in the previous report action but was included in the list now when the user scrolls down and newer actions are being loaded. Therefore, the correct way to determine it is a new message is that its created timestamp is now equal to the report lastVisibleActionCreated but unequal to the previous report lastVisibleActionCreated. So:

    const prevLastVisibleActionCreated = usePrevious(report.lastVisibleActionCreated);

        const isNewMessage = report.lastVisibleActionCreated === message.created && prevLastVisibleActionCreated !== message.created;

            const isNewMessage = report.lastVisibleActionCreated === message.created && prevLastVisibleActionCreated !== message.created;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

📣 @banjaminlee! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@kadiealexander, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@kadiealexander, @alitoshmatov Huh... This is 4 days overdue. Who can take care of this?

@alitoshmatov Any update here?

@kadiealexander, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Sorry, I have a lot on my plate. Will ask to other C reassignment

Taking over. Please assign to me @kadiealexander

@kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸