Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

Job added to Upwork: https://www.upwork.com/jobs/~021867142072270891331

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

After the user tries to submit an expense to a workspace without merchant, the displayed error message remains despite the field being completed. User is not able to submit the expense after the error is displayed.

What is the root cause of that problem?

If the merchant is required, an error will be displayed when we click on confirm button without enter a valid merchant.
The problem comes from here the merchant error isn't cleared after the confirmation is lost focus or the transaction is changed

Then the merchant error still exist after we change the merchant

What changes do you think we should make in order to solve the problem?

We need to clear any form error here instead of only special form error

clearFormErrors([formError]); // or we can use setFormError('')

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@Gonals @joekaufmanexpensify I can raise the quick PR if my proposal is correct

I can raise the quick PR if my proposal is correct

@dominictb proposal's RCA and solution makes sense to me. I think we can go ahead with the PR.
@Gonals @joekaufmanexpensify what do you think?

Reverting to setFormError('') won't work properly because it will clear other form errors that shouldn't be cleared. This will cause blinking:

Anyway, I think we should revert it as a follow-up of our #51517 and think of a better approach with these form errors in some following PR.

Anyway, I think we should revert it as a follow-up of our #51517 and think of a better approach with these form errors in some following PR.

@paultsimura Ah! Now I see why a selective clearFormErrors was used. I think the way errors are designed here is that it is triggered whenever we try to submit the expense. And reset the form error whenever the screen gains or lose focus. I think even the invalid rate error needs to align in a similar manner. Can we not fix it this way?

Or we can do a minimum fix using setFormError('') as this is a real blocker due to the fact that it affects the critical flow of submitting expenses.

Or we can do a minimum fix using setFormError('') as this is a real blocker due to the fact that it affects the critical flow of submitting expenses.

I agree with this, will raise a PR now, and we'll fix the rate error blinking in my other current PR as it's not critical.

Defer to @Gonals on the solution. If he's good, good with me!

I think I managed to fix both issues at once by just moving the useEffect around and reverting to setFormError('') .
The PR is ready: #54039, but I think it should be reviewed by @Pujan92 as a follow-up from our GH.

Sounds good to me too. We are going with @paultsimura's solution, then, @rojiphil?

Sounds good to me to have @Pujan92 review if this is a follow up from another issue

Yes, I am on it.

Fixed in staging

PR is merged

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Fully clear the form error #54039

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment (Needs manual offer from BZ)

@rojiphil @joekaufmanexpensify @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

PR is out on prod. There isn't any payment to be issued here. This issue was a regression from #51517 , which originally came from #46897. All payment will be handled here.

Going to close this for now, but LMK if anyone has questions on that!

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.76-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Fully clear the form error #54039

If no regressions arise, payment will be issued on 2024-12-25. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment (Needs manual offer from BZ)

@rojiphil @joekaufmanexpensify @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]