Proposal

Please re-state the problem that we are trying to solve in this issue.

Refactor createDistanceRequest to use a parameter

What is the root cause of that problem?

This is an improvement

What changes do you think we should make in order to solve the problem?

Wrap all parameters of this function into one object and in this object, we can have some sub-objects that will wrap the related data.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

@neil-marcellini I'm here.

I can take it as C based on this comment

@neil-marcellini Is this ready?

Job added to Upwork: https://www.upwork.com/jobs/~021866886683506920885

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Not actually a bug but assigning you to handle payment when the time comes.

@mkzie2's proposal looks good. Please go ahead and get started.

@dukenv0307 The PR is ready.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor createDistanceRequest function #53994

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment through NewDot Manual Requests
• @mkzie2 requires payment (Needs manual offer from BZ)

@dukenv0307 @OfstadC @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

• [Contributor] Classify the bug:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Refactor issue

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Open a workspace chat
2. Create a distance request
3. Verify that the request is created successfully

Do we agree 👍 or 👎

Hi @dukenv0307 @mkzie2 we have a deploy blocker #54513

Is it related to this?

@Christinadobrzyn My PR is deployed to production so I don't think it's related to the blocker.

Okay thanks for checking @mkzie2 - I'll keep digging to see if I can find what's linked to the blocker