Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Triggered auto assignment to @mjasikowski (AutoAssignerNewDotQuality)

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

This also happens in prod. Demoting to NAB.

Hm this feels like it might be backend, but definitely open to a front end solve if we have one! Will look shortly

Trying to replicate locally, apparently it's hard to get the email summaries to send.

Trying to get some help replicating this, once i can we can figure out the solution

Okay so I managed to reproduce finally. The issue looks like the formation of the link from the email, vs. how you get there from the app itself. I don't yet know exactly which parts are causing the biggest issues, but here's the details.

Link from email:

https://dev.new.expensify.com:8082/r/3058871422043474/attachment?source=https://www.expensify.com.dev/chat-attachments/5094796852905002131/w_53497515bb3b313ac8e88c4efded655601d91524.png

URL from navigating in App:

https://dev.new.expensify.com:8082/attachment?source=https://expensify-dgalerosen.ngrok.io/chat-attachments/5094796852905002131/w_53497515bb3b313ac8e88c4efded655601d91524.png&type=r&reportID=3058871422043474&isAuthTokenRequired=true&fileName=Screenshot_2024-12-10_at_12.27.42.png

Differences:

https://dev.new.expensify.com:8082
**[EMAIL LINK HAS /r/<reportID>]**
/attachment?source=
[EMAIL HAS OLD DOT LINK, URL HAS NEW]
chat-attachments/5094796852905002131/w_53497515bb3b313ac8e88c4efded655601d91524.png
[URL HAS &type=r&reportID=3058871422043474&isAuthTokenRequired=true&fileName=Screenshot_2024-12-10_at_12.27.42.png]

Playing around, I think a few things are happening:

• The report needs to be passed as a URL param, NOT as part of the url
• Possibly, the source needs to be a newdot link, though I'm not sure about that
• fileName and isAuthTokenRequired seem to possibly not be required, though that seems odd on the latter front.
• I'm not sure about type

The nice thing is that it's consistent, it's not about whether or not the user has access to the particular report or attachment or whatever. That is, after I successfully open it, the email link still doesn't work. So it should be easy to reproduce / update that link once I find the logic.

hey @Gonals it looks like you wrote the initial URL that we use for attachment email links (here). any ideas on why these aren't working anymore?

That was a while ago, but it seems we have changed the URLs in Newdot?

Yeah hrm. Okay so I've got nearly all of what we need. I've updated the backend to use the right format:

URL_TO_NEW_DOT.'attachment?source='.$url.'&type=r&reportID='.$reportID;

This works on dev! Yay! However, I looked into production a little bit and I'm not 100% sure it will solve the problem. I found a recent image from the social channel. The link I received in my email (which doesn't work) was

https://new.expensify.com/r/6549335221793525/attachment?source=https://www.expensify.com/chat-attachments/1994588430180453104/w_ab9f5e72faca59f0bc1888e27f087a52d683bf6b.jpg

Adapting that into what my updated backend will send, we'll get:

https://new.expensify.com/attachment?source=https://www.expensify.com/chat-attachments/1994588430180453104/w_ab9f5e72faca59f0bc1888e27f087a52d683bf6b.jpg&type=r&reportID=6549335221793525

Unfortunately, that still doesn't work. Let's keep going.

The link that actually works, via App, is

https://new.expensify.com/attachment?source=https://www.expensify.com/chat-attachments/7162688893835784434/w_c622099d5dc912677747f0b1d9b2b0d91da26598.jpg&type=r&reportID=6549335221793525&isAuthTokenRequired=true&fileName=7863B93F-3659-4022-95AF-05728EADA518.jpg

Adapting that into the same format from my change, it still works like this:

https://new.expensify.com/attachment?source=https://www.expensify.com/chat-attachments/7162688893835784434/w_c622099d5dc912677747f0b1d9b2b0d91da26598.jpg&type=r&reportID=6549335221793525

At this point, we're at exactly the same link [format] as my new format. But it looks like the email link still wouldn't work, even with the changes - because the reportActionID (I assume that's what the numbers after chat-attachments are?) and the file name (w_....) are different.

I'm hoping that's unrelated, and it might work if we push this change? I'm heartened by it working on dev... but that's definitely peculiar.

BE fix that should hopefully fix this is merged, not yet deployed

Okay it did not fix it, I'm waiting to get a new image link so I can try to identify what else we can try.

@dangrous want me to send you an image? Don't open the DM so it will ship to your email.

that would be great @davidcardoza ! I just tried sending myself one from my expensifail account but it didn't come through, even after way more than 10 minutes... maybe yours will work

Sent a pic over via DM, it's a beaut.

So in that testing ^ it DID work as expected. Do you think we should have QA re-test this one more time?

I'll also send you one @davidcardoza for another local test.

Okay so it seems to work MORE of the time now, but not all the time.

• David -> Daniel worked!
• Daniel -> David worked!
• Another David -> Daniel didn't work on first click, but did on second.
• Another photo I happened to see come through worked!

I... am not sure what to do with that info haha. We're batting .750-1.000 but not certain it's enough. What do we think?

@JmillsExpensify @mjasikowski @dangrous this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@JmillsExpensify, @mjasikowski, @dangrous Whoops! This issue is 2 days overdue. Let's get this updated quick!

@JmillsExpensify, @mjasikowski, @dangrous Huh... This is 4 days overdue. Who can take care of this?