Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

## Proposal #53626

Closed
usamazeeshan5 opened this issue Dec 5, 2024 · 1 comment
Closed

## Proposal #53626

usamazeeshan5 opened this issue Dec 5, 2024 · 1 comment

Comments

@usamazeeshan5
Copy link

          ## Proposal

Please re-state the problem that we are trying to solve in this issue.

The group conversation shown in LHN without any message or history

What is the root cause of that problem?

After we rename the report, notificationPreference of the user is updated to always. So it stays in LHN.

Screenshot 2024-12-04 at 15 00 08

What changes do you think we should make in order to solve the problem?

In updateGroupChatName function, we should update notificationPreference of the current user to always if it's hidden.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

To clarify, I think we can add a new action when we edit the group chat name like we do when we update the policy room name

  1. We can define a new action type for updating the group chat name and create an optimistic action when we update the group chat name like we do here

function updateGroupChatName(reportID: string, reportName: string) {

  1. Define a new function to get the translated message for the new action. And update a case for this action in LHN, ReportActionItem, getReportName, copyToClipBoard.

Originally posted by @nkdengineer in #53496 (comment)

Copy link

melvin-bot bot commented Dec 5, 2024

📣 @usamazeeshan5! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

@melvin-bot melvin-bot bot closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant