Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Edited by proposal-police: This proposal was edited at 2024-12-16 10:22:05 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The group conversation shown in LHN without any message or history

What is the root cause of that problem?

After we rename the report, notificationPreference of the user is updated to always from the backend. So it stays in LHN even we click on another report.

What changes do you think we should make in order to solve the problem?

In updateGroupChatName function, we should update notificationPreference of the current user in optimisticData to always if it's hidden.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a test case for updateGroupChatName function and verify that notificationPreference is updated to always in optimistic data.

What alternative solutions did you explore? (Optional)

To clarify, I think we can add a new action when we edit the group chat name like we do when we update the policy room name

1. We can define a new action type for updating the group chat name and create an optimistic action when we update the group chat name like we do here

2. Define a new function to get the translated message for the new action. And update a case for this action in LHN, ReportActionItem, getReportName, copyToClipBoard.

Job added to Upwork: https://www.upwork.com/jobs/~021864491578413816640

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

1: What is the root cause of that problem?
left hand navigations not updating properly.
2: What changes do you think we should make in order to solve the problem?
Implement a check in updateGroupChatName to handle this logic. This ensures that
only the required groups appear in the LHN based on the user's preferences.
3:What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Multiple rename operations.
Renaming after modifying other group properties like participants or settings.
Groups with no history or messages.

📣 @usamazeeshan5! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

1: What is the root cause of that problem?
left hand navigations not updating properly.
2: What changes do you think we should make in order to solve the problem?
Implement a check in updateGroupChatName to handle this logic. This ensures that
only the required groups appear in the LHN based on the user's preferences.
3:What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Multiple rename operations.
Renaming after modifying other group properties like participants or settings.
Groups with no history or messages.

Thanks for the proposal @nkdengineer

Can you please add more details in RCA, solution and test section of your proposal.

@sobitneupane, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Waiting for proposal.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@sobitneupane, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Waiting for proposal.

@nkdengineer If you are still interested, #53496 (comment)

@sobitneupane Updated my proposal.

@sobitneupane @adelekennedy this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

After we rename the report, notificationPreference of the user is updated to always from the backend. So it stays in LHN even we click on another report.

@nkdengineer So, the report appears in the LHN because the backend sets the notificationPreference to "always," correct?

In updateGroupChatName function, we should update notificationPreference of the current user in optimisticData to always if it's hidden.

How does this solve the issue? Wouldn't we want the notificationPreference to remain "hidden"? IMO, the backend shouldn't change the notificationPreference to "always" when renaming the group chat if the intention is to keep it hidden.

The same should apply to sending and deleting messages in a group. If all messages in a group are deleted, and the group has no messages, its notificationPreference should be set to "hidden."

@nkdengineer So, the report appears in the LHN because the backend sets the notificationPreference to "always," correct?

Yes.

@sobitneupane I think we can ask internal about the expected behavior. If hidden is expected we should fix it from the backend side.

If always is expected, what do you think about my alternative solution that will add a system message when we update the group chat name

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

I think we can ask internal about the expected behavior. If hidden is expected we should fix it from the backend side.

For sending and deleting a message in a group, the "hidden" behavior seems preferable. However, for renaming a group, it might be better to show the group in LHN with a "group name updated" message. The former will require backend changes, so I’m referring it to an internal engineer.

🎀 👀 🎀 C reviewed.

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@AndrewGable, @sobitneupane, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@AndrewGable, @sobitneupane, @adelekennedy Eep! 4 days overdue now. Issues have feelings too...

@AndrewGable, @sobitneupane, @adelekennedy Still overdue 6 days?! Let's take care of this!