-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Cannot make an expense negative #53441
Comments
Triggered auto assignment to @johncschuster ( |
Job added to Upwork: https://www.upwork.com/jobs/~021866173019746429432 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach ( |
Potentially a new feature - asking in thread. |
Hi, I'm Eugene from Callstack - expert contributor group. I’d like to work on this issue. |
Should I create just a PR here without the proposal? |
📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
In this case, should we allow the entry of a plus sign, calculate the combinations result, and send the computed result to the API? |
@pasyukevich |
Yes, I think this would be great - we need some discussion here for the expected behavior |
🎀👀🎀 |
Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@twisterdotcom is there more context on why a user would use these characters when editing an expense? I think some more information on what we're trying to achieve might help contributors understand what we're trying to do here and help move this along. Thanks! |
Maybe we can try to track down someone who has more familiarity with negative expenses to help investigate this. I'll be going on leave sometime in the next few weeks and probably won't get to this before then. |
@johncschuster @pasyukevich @marcaaron @ZhenjaHorbach this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Sure, I see three fairly likely use cases:
|
@johncschuster, @pasyukevich, @marcaaron, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue |
Current assignee @ZhenjaHorbach is eligible for the External assigner, not assigning anyone new. |
🎀👀🎀 |
Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Nor overdue |
Yes, let's allow typing the minus sign. Let me know if sending it to the api doesn't act as expected and I can look into it. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.70-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @twisterdotcom
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs
Action Performed:
Expected Result:
User able to enter minus, plus or Brackets
Actual Result:
User unable to enter minus, plus or Brackets
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Recording.815.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @The text was updated successfully, but these errors were encountered: