Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Cannot make an expense negative #53441

Open
1 of 8 tasks
m-natarajan opened this issue Dec 3, 2024 · 25 comments
Open
1 of 8 tasks

[$250] Cannot make an expense negative #53441

m-natarajan opened this issue Dec 3, 2024 · 25 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Overdue

Comments

@m-natarajan
Copy link

m-natarajan commented Dec 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.70-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @twisterdotcom
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

  1. SmartScan a receipt
  2. Open the expense
  3. Open the amount
  4. Try to correct it to be negative. No way to add brackets or - sign.

Expected Result:

User able to enter minus, plus or Brackets

Actual Result:

User unable to enter minus, plus or Brackets

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Shottr 2024-12-03 10 02 13

Recording.815.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021866173019746429432
  • Upwork Job ID: 1866173019746429432
  • Last Price Increase: 2024-12-28
  • Automatic offers:
    • ZhenjaHorbach | Reviewer | 105292850
Issue OwnerCurrent Issue Owner: @
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Dec 3, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label Dec 9, 2024
@johncschuster johncschuster added the External Added to denote the issue can be worked on by a contributor label Dec 9, 2024
@melvin-bot melvin-bot bot changed the title Cannot make an expense negative [$250] Cannot make an expense negative Dec 9, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021866173019746429432

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 9, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

@garrettmknight
Copy link
Contributor

Potentially a new feature - asking in thread.

@garrettmknight garrettmknight moved this to Future Cohort Project in [#whatsnext] #expense Dec 10, 2024
@garrettmknight garrettmknight moved this from Future Cohort Project to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 10, 2024
@pasyukevich
Copy link
Contributor

Hi, I'm Eugene from Callstack - expert contributor group. I’d like to work on this issue.

@pasyukevich
Copy link
Contributor

Should I create just a PR here without the proposal?

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 11, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@pasyukevich
Copy link
Contributor

In this case, should we allow the entry of a plus sign, calculate the combinations result, and send the computed result to the API?

@melvin-bot melvin-bot bot added the Overdue label Dec 13, 2024
@ZhenjaHorbach
Copy link
Contributor

@pasyukevich
If required I can assign a random engineer !

@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2024
@pasyukevich
Copy link
Contributor

@ZhenjaHorbach

Yes, I think this would be great - we need some discussion here for the expected behavior

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
@ZhenjaHorbach
Copy link
Contributor

🎀👀🎀

Copy link

melvin-bot bot commented Dec 16, 2024

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@marcaaron
Copy link
Contributor

User able to enter minus, plus or Brackets

@twisterdotcom is there more context on why a user would use these characters when editing an expense? I think some more information on what we're trying to achieve might help contributors understand what we're trying to do here and help move this along. Thanks!

@marcaaron
Copy link
Contributor

Maybe we can try to track down someone who has more familiarity with negative expenses to help investigate this. I'll be going on leave sometime in the next few weeks and probably won't get to this before then.

Copy link

melvin-bot bot commented Dec 17, 2024

@johncschuster @pasyukevich @marcaaron @ZhenjaHorbach this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@twisterdotcom
Copy link
Contributor

more context on why a user would use these characters when editing an expense?

Sure, I see three fairly likely use cases:

  1. A user is tracking personal expenses and chooses to invert everything SmartScan does to make expenses negative offsetting a positive single expenses total they create. (Uncommon, but it does happen on oldDot).
  2. Similar but a business user will do the same for pre-approval cash amount, and add SmartScanned expenses to offset that. (Again uncommon, but more common than 1)
  3. Like me, users may be indebted to the company a small amount, and this is how they are able to pay it back (by reneging on future expense reimbursements).
  4. SmartScan scans the amount wrong. (The most common)

Copy link

melvin-bot bot commented Dec 20, 2024

@johncschuster, @pasyukevich, @marcaaron, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2024
@ZhenjaHorbach
Copy link
Contributor

Not overdue
Maybe we should assign another random engineer following this comment

@melvin-bot melvin-bot bot removed the Overdue label Dec 20, 2024
@marcaaron marcaaron removed their assignment Dec 20, 2024
@marcaaron marcaaron added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Dec 20, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 20, 2024
Copy link

melvin-bot bot commented Dec 20, 2024

Current assignee @ZhenjaHorbach is eligible for the External assigner, not assigning anyone new.

@ZhenjaHorbach
Copy link
Contributor

🎀👀🎀

Copy link

melvin-bot bot commented Dec 20, 2024

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Copy link

melvin-bot bot commented Dec 21, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
@ZhenjaHorbach
Copy link
Contributor

Nor overdue
@nkuoch
Could you please help with this comment ?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 23, 2024
@nkuoch
Copy link
Contributor

nkuoch commented Dec 26, 2024

Yes, let's allow typing the minus sign. Let me know if sending it to the api doesn't act as expected and I can look into it.

@melvin-bot melvin-bot bot removed the Overdue label Dec 26, 2024
Copy link

melvin-bot bot commented Dec 28, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Overdue
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

8 participants