Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-17] [$250] Android - Report auto closes when opening WS settings via deep link and returning to chat #53377

Closed
3 of 7 tasks
IuliiaHerets opened this issue Dec 2, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch ND or hybrid app.
  2. Create a new workspace.
  3. Go to workspace settings > More features.
  4. Enable Report fields and upgrade to Control plan.
  5. Close and reopen the app (important).
  6. Open workspace switcher and select the upgraded Control workspace.
  7. Go to #admins.
  8. Tap "here" link in the whisper message.
  9. Tap app back button three times.

Expected Result:

App will return to #admins (production behavior).

Actual Result:

Describe what actually happenedApp returns to #admins, then it auto navigates to LHN with workspace filter cleared.
On iOS, it directly opens LHN with workspace filter cleared.

Workaround:

Unknown

Platforms:

  • [x ] Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6681794_1733137258528.Screen_Recording_20241202_170049__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863543484433627612
  • Upwork Job ID: 1863543484433627612
  • Last Price Increase: 2024-12-02
  • Automatic offers:
    • ZhenjaHorbach | Reviewer | 105156060
Issue OwnerCurrent Issue Owner: @sonialiap
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 labels Dec 2, 2024
@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 2, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MariaHCD
Copy link
Contributor

MariaHCD commented Dec 2, 2024

Looks like a navigation issue. But it's not a breaking bug and does not have a very huge impact on the user experience. Demoting from a deploy blocker but let's investigate and fix!

@MariaHCD MariaHCD added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment labels Dec 2, 2024
@melvin-bot melvin-bot bot changed the title Android - Report auto closes when opening WS settings via deep link and returning to chat [$250] Android - Report auto closes when opening WS settings via deep link and returning to chat Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021863543484433627612

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

@MariaHCD MariaHCD added Daily KSv2 and removed Hourly KSv2 labels Dec 2, 2024
@adamgrzybowski
Copy link
Contributor

@mountiny I will take a look at this one

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Dec 10, 2024
@melvin-bot melvin-bot bot changed the title [$250] Android - Report auto closes when opening WS settings via deep link and returning to chat [HOLD for payment 2024-12-17] [$250] Android - Report auto closes when opening WS settings via deep link and returning to chat Dec 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 10, 2024

@ZhenjaHorbach @sonialiap @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@sonialiap sonialiap removed their assignment Dec 13, 2024
@sonialiap sonialiap added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 13, 2024
@sonialiap
Copy link
Contributor

I'm OOO Dec 16-20, adding a leave buddy

next steps:

  • make payments on the 17th
  • complete checklist

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Dec 17, 2024

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

https://github.com/Expensify/App/pull/40016/files#r1889116316

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    NA

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • BZ add regression test

Regression Test Proposal

  1. Launch App
  2. Create a new workspace
  3. Go to workspace settings > More features
  4. Enable Report fields and upgrade to Control plan
  5. Close and reopen the app (important)
  6. Open workspace switcher and select the upgraded Control workspace
  7. Go to #admins
  8. Tap "here" link in the whisper message
  9. Tap app back button three times
  10. Verify that the app will return to #admins

Do we agree 👍 or 👎

Copy link

melvin-bot bot commented Dec 20, 2024

@sonialiap, @mallenexpensify, @mountiny, @adamgrzybowski, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2024
@ZhenjaHorbach
Copy link
Contributor

Not overdue
We are waiting for payment

@mallenexpensify
Copy link
Contributor

Contributor : @ZhenjaHorbach paid $250 via Upwork

@ZhenjaHorbach , apologies for the delay. Can you propose regression test steps? I want to create a test case, in case QA wants to add or update one. Thx

@ZhenjaHorbach
Copy link
Contributor

Contributor : @ZhenjaHorbach paid $250 via Upwork

@ZhenjaHorbach , apologies for the delay. Can you propose regression test steps? I want to create a test case, in case QA wants to add or update one. Thx

Thanks for payment !
I have updated Bugzero checklist and included regression test steps

@sonialiap
Copy link
Contributor

sonialiap commented Dec 23, 2024

Thanks Matt and Zhenja!

Added regression test update. Closing out

@melvin-bot melvin-bot bot removed the Overdue label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants