Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Hybrid - iOS - Split - "User split $0" notifications received when user split expense via scan, iOS Hybrid app crashes #53302

Open
1 of 8 tasks
IuliiaHerets opened this issue Nov 29, 2024 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Overdue

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.68-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5275241
Issue reported by: Applause Internal Team

Action Performed:

Preconditions: User A signed in in Desktop app, User B in iOS Hybrid app, User C in Web.

  1. As User A navigate to staging.new.expensify desktop app.
  2. Create a group chat with users B and C.
  3. In the group chat click " " button, Split expense, Scan.
  4. Click Choose file and select pdf or png receipt.
  5. Split expense, verify the receipt is in scanning status.

Expected Result:

Users B and C do not receive "User A split $0" notifications while the receipt is scanning, iOS Hybrid app does not crash.

Actual Result:

Users B and C receive "User A split $0" notifications while the receipt is scanning, iOS Hybrid app crashes.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2911_1.txt

Bug6679583_1732835707346.split__0.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021864470651196859868
  • Upwork Job ID: 1864470651196859868
  • Last Price Increase: 2024-12-26
Issue OwnerCurrent Issue Owner: @eVoloshchak
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 29, 2024
Copy link

melvin-bot bot commented Nov 29, 2024

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 2, 2024

@VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@VictoriaExpensify
Copy link
Contributor

I haven't had a chance to look at this yet, but will do today

@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2024
@VictoriaExpensify VictoriaExpensify added the External Added to denote the issue can be worked on by a contributor label Dec 5, 2024
Copy link

melvin-bot bot commented Dec 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021864470651196859868

@melvin-bot melvin-bot bot changed the title Hybrid - iOS - Split - "User split $0" notifications received when user split expense via scan, iOS Hybrid app crashes [$250] Hybrid - iOS - Split - "User split $0" notifications received when user split expense via scan, iOS Hybrid app crashes Dec 5, 2024
@melvin-bot melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels Dec 5, 2024
Copy link

melvin-bot bot commented Dec 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Copy link

melvin-bot bot commented Dec 10, 2024

@eVoloshchak, @VictoriaExpensify Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Dec 10, 2024
@eVoloshchak

This comment was marked as outdated.

Copy link

melvin-bot bot commented Dec 12, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

@eVoloshchak @VictoriaExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Dec 16, 2024

@eVoloshchak, @VictoriaExpensify Eep! 4 days overdue now. Issues have feelings too...

@maddylewis maddylewis moved this to Product (CRITICAL) in [#whatsnext] #retain Dec 16, 2024
@eVoloshchak
Copy link
Contributor

Not overdue, this is awaiting proposals

@melvin-bot melvin-bot bot removed the Overdue label Dec 16, 2024
@truph01
Copy link
Contributor

truph01 commented Dec 19, 2024

I think the push notification should be fixed on the BE side. Here is an example about the push notification payload:

{
  "pushPayload": {
    "title": "123123 in 123123, truphd01 1002, truphd01 [email protected]",
    "alert": "split ₫0",
    "extras": {
      "com.urbanairship.title": "123123 in 123123, truphd01 1002, truphd01 [email protected]",
      "com.urbanairship.notification_channel": "1443339497863742",
      "com.urbanairship.push.ALERT": "split ₫0",
      "com.urbanairship.push.PUSH_ID": "41f88065-bde5-11ef-8cd5-02425ea0ca56",
      "payload": {
        "type": "moneyRequest",
        "title": "123123 in 123123, truphd01 1002, truphd01 [email protected]",
        "onyxData": [
          {
            "key": "report_1443339497863742",
            "onyxMethod": "merge",
            "value": {
              "chatType": "group",
              "description": "",
              "lastActorAccountID": 18852838,
              "lastMessageText": "split ₫0",
              "lastVisibleActionCreated": "2024-12-19 08:42:57.618",
              "managerID": null,
              "ownerAccountID": 0,
              "parentReportActionID": null,
              "parentReportID": null,
              "policyID": "_FAKE_",
              "reportID": "1443339497863742",
              "reportName": "",
              "state": "OPEN",
              "stateNum": 0,
              "statusNum": 0,
              "type": "chat",
              "visibility": null
            }
          },
          {
            "key": "reportActions_1443339497863742",
            "onyxMethod": "merge",
            "shouldShowPushNotification": true,
            "value": {
              "3632765990272408978": {
                "actionName": "IOU",
                "actorAccountID": 18852838,
                "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_23.png",
                "created": "2024-12-19 08:42:57.618",
                "lastModified": "2024-12-19 08:42:57.618",
                "message": [
                  {
                    "html": "split ₫0",
                    "text": "split ₫0",
                    "type": "COMMENT",
                    "whisperedTo": []
                  }
                ],
                "originalMessage": {
                  "IOUTransactionID": "5431236517416942070",
                  "amount": 0,
                  "comment": "",
                  "currency": "VND",
                  "isNewDot": true,
                  "lastModified": "2024-12-19 08:42:57.618",
                  "participantAccountIDs": [17924662, 18834150, 18852838],
                  "type": "split"
                },
                "person": [
                  {
                    "style": "strong",
                    "text": "123123",
                    "type": "TEXT"
                  }
                ],
                "reportActionID": "3632765990272408978",
                "shouldShow": true
              }
            }
          }
        ],
        "previousUpdateID": 3488818789,
        "lastUpdateID": 3488827401,
        "reportID": "1443339497863742",
        "reportActionID": "3632765990272408978",
        "roomName": "",
        "app": "new"
      },
      "com.urbanairship.push.CANONICAL_PUSH_ID": "40d6e3c0-bde5-11ef-8bbf-0000a1ace0f5",
      "com.urbanairship.priority": "high",
      "com.urbanairship.push.APID": "e1ae76b5-72a9-41cd-afdf-8c3ec5806f07",
      "com.urbanairship.metadata": {
        "version_id": 1,
        "time": 1734597782374,
        "push_id": "40d6e3c0-bde5-11ef-8bbf-0000a1ace0f5",
        "campaigns": {
          "categories": []
        },
        "context": {}
      }
    }
  }
}

@melvin-bot melvin-bot bot added the Overdue label Dec 19, 2024
Copy link

melvin-bot bot commented Dec 19, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Dec 20, 2024

@eVoloshchak, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Dec 24, 2024

@eVoloshchak, @VictoriaExpensify Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Dec 26, 2024

@eVoloshchak, @VictoriaExpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Dec 26, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Dec 27, 2024

@eVoloshchak @VictoriaExpensify this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Overdue
Projects
Status: Product (CRITICAL)
Development

No branches or pull requests

4 participants